Skip to content

floor_naming_hygiene's module annotation names a subject #11799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gunbai-bot wants to merge 1 commit into from
Closed

floor_naming_hygiene's module annotation names a subject #11799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions src/v2/workflow/floor_naming_hygiene.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@ import v2.std.optional {
}
import v2.std.algebra { fold_list }

// SINGLE AUTHORITY for floor witness sidecar placement and the test-decl name scan predicates. Host
// discovery walks files and projects rows; these pure fns decide whether an entry placement is
// admissible and which decls a *_test.dag enrols.
//
// The line scan is still a SECOND PARSER of the authored `test` marker. Its replacement is not a
// refactor of this module: it needs the canonical parser to retain the marker, which v1 now does
// (v1.std.core DeclarationMarker TestMarked, set by v1.compiler.parse test_marked_item_result) and
// so does v2 (v2.extdeps.languages.dag dag_production_test_fn_decl parses it; v2.compiler.test_marker_capture
// carries it on its own channel). The grammar is no longer the obstacle; cost is, because floor
// discovery deliberately neither parses nor resolves the files it enumerates. The TRIGGER for
// retiring the scan is stated once, beside the producer it retires, at v2.compiler.body_lowering_fold
// body_lower_test_fn_decl_to_member -- not restated here, so the two cannot drift.
data floor_test_sidecar_suffix: String = "_test.dag"
data floor_wire_contract_sidecar_suffix: String = "_contracts.dag"

Expand Down Expand Up @@ -236,16 +248,3 @@ fn floor_entries_requiring_test_sidecar(entry_paths: List<String>) -> List<Strin
}
)
}

// SINGLE AUTHORITY for floor witness sidecar placement and the test-decl name scan predicates. Host
// discovery walks files and projects rows; these pure fns decide whether an entry placement is
// admissible and which decls a *_test.dag enrols.
//
// The line scan is still a SECOND PARSER of the authored `test` marker. Its replacement is not a
// refactor of this module: it needs the canonical parser to retain the marker, which v1 now does
// (v1.std.core DeclarationMarker TestMarked, set by v1.compiler.parse test_marked_item_result) and
// so does v2 (v2.extdeps.languages.dag dag_production_test_fn_decl parses it; v2.compiler.test_marker_capture
// carries it on its own channel). The grammar is no longer the obstacle; cost is, because floor
// discovery deliberately neither parses nor resolves the files it enumerates. The TRIGGER for
// retiring the scan is stated once, beside the producer it retires, at v2.compiler.body_lowering_fold
// body_lower_test_fn_decl_to_member -- not restated here, so the two cannot drift.