Repository navigation
v2 manual tests: stop referencing test fns - #11579
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… witness) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Split: the — sent from snappy-koi-46 |
# Conflicts: # src/v2/workflow/floor_grandfathered_roster.dag
briansrls
left a comment
There was a problem hiding this comment.
REQUEST CHANGES — exact head bbf993e
The deletion-only conversions are sound, but two blockers remain.
inhabitant_neutralizationlaunders the same test verdict through an ordinaryfn.
v2.test.manual.ingest_bridge.ingest_cross_language_compile_accepts_holds is exactly:
check_ingest_cross_language_compile_accepts()
This PR changes inhabitant_neutralization_same_language_cross_language_compile_accepts_holds from calling that test fn to calling the same Boolean helper, and inhabitant_neutralization_03_ingest_regression_guard_holds still conjoins the result. The production path and assertion are unchanged; only the marker that #11580 will refuse has been bypassed. That still re-runs the ingest/infer claim inside an inhabitant-neutralization claim, contrary to the one-interface rule, and it establishes an escape hatch where any test-to-test composition can survive by moving the callee body behind a plain fn.
Remove the imported helper, the local forwarding helper, and that conjunct. The enrolled ingest_bridge.ingest_cross_language_compile_accepts_holds remains the sole claim for the ingest fact. If the neutralization claim genuinely needs an input from that boundary, supply the boundary value rather than invoke the other claim's complete Bool oracle.
- The branch predates the live shrink-only ledger and would strand twelve paid-down rows.
This head is 58 commits behind current main. Current main's v1.compiler.compile test_reference_debt() still carries the exact rows this diff removes:
- 3
field_access_emitrows; - 2
inhabitant_neutralizationrows (<import>and the call); - 3
record_construct_emitrows; - 3
rust_wire_serde_naming_policy_testrows; - 1
sg_rc_layeringrow.
After this cleanup they are declared=1, observed=0; the ledger's equality ratchet requires their deletion. The six WitnessDeleted rows in floor_grandfathered_roster answer witness enrollment, not test-reference debt. Merge current main, delete these twelve rows from src/v1/compile.dag, and regenerate src/v1/stage0/src/v1_compiler_compile.rs. Keep the two cross_language_add_python_to_typescript rows; that cleanup remains in #11593.
Gate note: the exact-head run attached to bbf993e is the older four-job workflow and did execute the floor. Current main has since changed the required witnesses status to aggregate hosted compiler and clippy lanes, with no floor lane. After integrating main, the landing claim should name that current gate rather than call this historical exact-head run build-only.
briansrls
left a comment
There was a problem hiding this comment.
REQUEST CHANGES — exact head de4d48e
The two semantic blockers from my prior review are closed correctly:
inhabitant_neutralizationno longer reaches the ingest-bridge claim through either thetest fnor its ordinary Boolean helper. The import, forwarding helper, and conjunct are deleted, so this PR does not establish the ordinary-helper escape hatch.src/v1/compile.dagdeletes the twelve paid-down debt rows while retaining the twocross_language_add_python_to_typescriptrows assigned elsewhere.
One blocking generated-source mismatch remains.
src/v1/stage0/src/v1_compiler_compile.rs still contains all twelve rows removed from src/v1/compile.dag (the field-access, inhabitant-neutralization, record-construction, rust-wire-serde, and sg-rc identities). The ledger commit 431ec8db36bad57765b1784694d98c133658a0d3 touched only src/v1/compile.dag; the stage0 mirror is not in the PR diff.
That means the authored compiler source and the Rust seed used by cargo build -p v1-compiler disagree about the live admission ledger. The green compiler/clippy jobs only prove the stale mirror compiles. The green heal job is not proof of source/mirror equality: its workflow regenerates in its checkout and produces a sealed repair candidate; it does not fail merely because this stage0 file differs, and on this head the committed mirror demonstrably still carries the deleted rows.
Required repair:
- regenerate and commit
src/v1/stage0/src/v1_compiler_compile.rsfrom the updatedsrc/v1/compile.dagso those same twelve rows disappear from the executable mirror; - update the PR body, which still says
inhabitant_neutralizationcalls the plain helper and still claims thecross_language_add_python_to_typescriptcleanup is in this PR. Neither statement describes this exact head.
The exact-head compiler, clippy, aggregate witnesses, and heal jobs are green. No floor ran and no floor receipt is claimed. I found no additional semantic defect in the manual-test cleanup.
…nce ledger as the authored .dag The 'drop the twelve rows' commit changed only src/v1/compile.dag, so the Rust seed Cargo actually builds still carried all twelve identities. Verified by regeneration reaching first_generation_equal=true, not by the heal job: that job regenerates inside its own checkout and carries no clean-tree assertion, so a committed mirror difference does not fail it.
briansrls
left a comment
There was a problem hiding this comment.
APPROVED at exact head c44f293.
Both prior source holds are closed. The neutralization guard now deletes the cross-test re-assertion rather than routing it through an ordinary helper, so it does not create the lexical-marker escape hatch. The authored test-reference ledger removes exactly the twelve paid-down rows while retaining both cross_language_add rows assigned elsewhere.
The stage0 fixed point is now committed. v1_compiler_compile.rs removes the same five identity families as src/v1/compile.dag; the full regeneration also carried the independently owed crate-layout and std_measure outputs. This is not being inferred from the former heal workflow: the exact-head required floor's Generated artifacts match their authorities step succeeded over the committed checkout.
The current gate shape has changed. On this exact SHA, required witnesses depended on successful floor, compiler, and clippy jobs. The floor built the compiler and witness executor, ran Nominal witnesses (one prepared subject, one fold), and checked generated artifacts against their authorities. All four jobs, including the aggregate status, succeeded.
That restoration does not by itself recreate the old materialization-cost instrument: this run published no required_floor_claim_cost/shared-fill artifacts. It establishes nominal witness execution and committed generated-artifact equality, not a present-versus-absent serve-cost comparison.
No remaining source-level hold.
|
Enqueued at c44f293 with the side chat's approval and all four required jobs green. What that green proves on this exact head, stated precisely because the gate shape changed mid-flight: the required workflow ran What it does not prove: this run published no — sent from proud-tern-736 |
The manual area of the v2 references to test code, cleared before the v2 refusal lands (node adhoc-f8d8160b-c82; owner decision: fix outright, no ledger). This clears every
v2.test.manual.*row of the census in #11505's ledger excepttypescript_descriptor_node_run_support, which another PR takes.field_access_emit_test,record_construct_emit_test: deleted six*_keystonetest fns. Each only called another enrolled test fn in the same module. Each deletion has a typedWitnessDeletedremoval infloor_grandfathered_roster.sg_rc_layering_test:sg_rc_f1_dual_boundary_holdsno longer conjoins the enrolledsg_rc_f1_value_dual_boundary_holds. That test still asserts its own fact.inhabitant_neutralization_test: DELETEDinhabitant_neutralization_same_language_cross_language_compile_accepts_holds, its import, and its conjunct in the03_ingest_regression_guard. Routing the same assertion through the plain fn would have kept the reach while shedding only the marker the wall refuses, which is an escape hatch;ingest_bridge.ingest_cross_language_compile_accepts_holdsstays the sole owner of that fact.rust_wire_serde_naming_policy_test: deleted threeUnifiedTestClaimdata rows whose only content was a reference to this module's owntest fns, which are already enrolled as themselves.src/v1/compile.dag: dropped the twelvetest_reference_debtrows this cleanup pays down (3 field_access_emit, 2 inhabitant_neutralization, 3 record_construct_emit, 3 rust_wire_serde, 1 sg_rc_layering). The twocross_language_add_python_to_typescriptrows stay: that cleanup is NOT in this PR and belongs to another change.src/v1/stage0/src/v1_compiler_compile.rs: the regenerated mirror, so the Rust seed Cargo builds carries the same ledger as the authored.dag. Verified by a local regen reachingfirst_generation_equal=true-- NOT by the heal job, whose green says a repair candidate could be produced inside its own checkout and carries no clean-tree assertion about the committed mirror.Evidence, from a freshly built
claim_batchwith PASS counts checked against each file's roster: field_access_emit 3/3, record_construct_emit 3/3, sg_rc_layering 9/9, inhabitant_neutralization 6/6, rust_wire_serde 3/3, andfloor_eval_step_budget_witness_test(the roster's removal fold) 27/27.Left as they are: two
witness_row_cost_basis.tsvrows still name deleted keystones. That file already holds stale rows (e.g.src/v2/lens/idempotency/…), so it is not an enrolment authority.🤖 Generated with Claude Code