Repository navigation
Model Mt. Jade / Wiwynn SV328R physical class facts #11529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b0f3f02
Model Mt. Jade class physical facts from OCP and Wiwynn SV328R.
8d500de
Separate Mt. Jade identity from one specimen's NIC and PSU.
1ac6fe4
Give shared PSU sensors measure carriers and a real ethernet consumer.
aba1d1c
Share OnboardNetworkController and stop encoding fans and BMC media a…
cfb1dea
Use one uncited-inlet standing and stop classifying the second BMC LA…
1bc568e
Do not widen BaseboardModel for Mt. Jade.
f15fe7d
Distinguish named vs unstated onboard NIC controllers.
3d77b4a
Climb Jade PSU count to Nat and type the SV328R OCP slot.
39f1ea9
Derive the Jade BMC PHY name from the reference-part row.
86acd29
Stop minting a second PcieCem/OcpNic3 on intake ethernet.
28906a9
Consume BmcFirmwareFamily and DimmBuffering instead of nicknames.
4ab90b9
Admit the six TargetChanged bindings this hoist produced.
c39b41a
Merge remote-tracking branch 'origin/main' into session/proud-owl-749…
e6b116e
Delete consumed namespace-wave admissions on this roster touch.
eceb14c
Stop calling dual-AC a redundant path, and stop calling a PHY a contr…
b855647
Restore the CRPS witness declaration the fan dual_rotor edit dropped.
b3c9c2e
Refuse unit identity from unobserved port prose, and decompose 1+1 in…
f5887a4
Bind Collins BMC ports to the unit key, and count SV328R cores as Phy…
b1fd2b6
Delete stale PHY/PSU namespace-wave admissions that never matched the…
1cbb0bb
Merge origin/main into session/proud-owl-749-mtjade-physical.
44a23cd
Refuse unobserved Ethernet functions as a third standing, not a Bool.
483096b
Fold Ethernet function identity onto coproduct ==, and drop unused SV…
8f4a324
Cite Ampere vendor, Altra family authority, and AArch64 on SV328R ins…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| module extdeps.vendor.wiwynn | ||
|
|
||
| import extdeps.vendor { Vendor } | ||
| import extdeps.hardware { Hardware } | ||
|
|
||
| import std.decl_ref { DeclarationRef, WholeDeclaration } | ||
| import extdeps.external_authority { ExternalAuthority, ExternalModelScope, ExternalSubjectRef } | ||
| import extdeps.uri { Uri, Https } | ||
|
|
||
| data extdeps_external_authority_anchor: ExternalAuthority = ExternalAuthority { | ||
| uri: Uri { | ||
| scheme: Https | ||
| locator: "www.wiwynn.com" | ||
| } | ||
| } | ||
|
|
||
| data extdeps_model_scope: ExternalModelScope = ExternalModelScope { | ||
| subject: ExternalSubjectRef { | ||
| declaration: DeclarationRef { | ||
| module_path: "extdeps.vendor.wiwynn", | ||
| decl_name: "wiwynn_vendor", | ||
| field: WholeDeclaration | ||
| } | ||
| }, | ||
| first_citation: extdeps_external_authority_anchor, | ||
| further_citations: [] | ||
| } | ||
|
|
||
| data wiwynn_vendor: Vendor<Hardware> = Vendor { legal_name: "Wiwynn Corporation" } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking — this joins a PHY into a controller field.
mt_jade_bmc_ethernet_phyis explicitly aMtJadeReferencePartRowwhose role isBmcEthernetPhy; assigning its OPN toOnboardControllerIdentityasserts that RTL8211E is the controller. Keep the controller unstated unless the cited source names the MAC/controller, or split the shared carrier into controller/MAC and PHY identities and bind AST2500/RTL8211E to their actual roles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed: mt_jade_bmc_management_network.controller is OnboardControllerUnstated; RTL8211E is NamedOnboardPhy only. AST2500 stays on the BMC chip catalog row.