Repository navigation
test methodology - #11487
Closed
gunbai-bot[bot] wants to merge 9 commits into
Closed
test methodology#11487gunbai-bot[bot] wants to merge 9 commits into
gunbai-bot[bot] wants to merge 9 commits into
Conversation
`test fn` / `test data` now parse to ModuleItemTestFunction / ModuleItemTestDataValue rather than being stripped by drop_leading_test_marker. A `test` marker before any other item form is refused instead of silently ignored. Consumers that only ask what shape an item has read module_item_kind_shape, so emission and extdeps data reading are unchanged. Prerequisite for refusing references to a test fn at resolve. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
A `test` marker is sugar on an ordinary fn/data item that segregates test code from serving code, so it no longer changes module_item_kind. Node carries declaration_marker: Unmarked | TestMarked; rebuilds copy it, everything else is Unmarked. Emitters and cli_run.rs are back to main. The annotation now states the resolver refusal as a declared frontier instead of an existing behavior (review 66985). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ed kind `pattern` and `interface` are BlockBody forms whose constructor stamps ModuleItemFunction, so checking the parsed kind admitted `test pattern` and `test interface`. Admissibility now reads the ItemForm body_kind before the item is parsed (ExprBody = fn, ValueBody = data); the refusal test covers both forms. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
v1.compiler.compile test_reference_diagnostics runs after inference over the typed graph: a call to a TestMarked declaration from anywhere (including another test) and an import of a test-declaring module by a module that declares none are TestCodeReferenced (blocking). Existing references are admitted per (module, referrer) with an exact count in test_reference_debt (153 rows, 1175 references across dag and src/v2); a row whose observed count differs in either direction is TestCodeReferenceBudgetMismatch (blocking). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…advisory class Addresses review 67156: ledger rows key on (module, referrer, target) with a dissolution condition (1135 rows); TestCodeReferenceAdmitted has an advisory_class_ceilings row; a TestMarked declaration used as a function value or named in an import is a reference; the boolean marker helper is gone; the DeclarationMarker frontier annotation now names its consumer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…dratic fold (review 67195) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…6-test-refusal # Conflicts: # src/v1/stage0/src/v1_compiler_emit_rust.rs # src/v1/stage0/src/v1_compiler_infer_method.rs
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Duplicate auto-draft of session/proud-tern-736-test-refusal; that branch is #11505, which carries the reviews and CI. Closing to stop duplicate check notices. — sent from proud-tern-736 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
proud-tern-736.Pushing to
session/proud-tern-736-test-refusaladvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan