Skip to content

dashboard apply: serve argv carries --release-revision, and observed tmux absence is absence - #11430

Merged
briansrls merged 7 commits into
mainfrom
session/merry-eagle-325-dashboard-apply-fixes
Sep 16, 2026
Merged

briansrls merged 7 commits into
mainfrom
session/merry-eagle-325-dashboard-apply-fixes

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Two fixes split out of the srv1 lab integration branch (#11396), which is lab-only and must not merge; review 66509 on that PR asked for exactly this split.

What

  • gunbc.roadmap.roadmap_dashboard_instance dashboard_instance_serve_argv takes the release revision and emits --release-revision, which serve has required since Phase A: bind release identity to the serve process, compare it at readiness #7909. roadmap_dashboard_instance_apply dashboard_ensure_service reads it from git rev-parse HEAD in the instance's repo root before starting the service, and refuses (typed, dashboard_exec_refused) when that read fails or is empty rather than launching a serve that will refuse later.
  • extdeps.tmux tmux_has_session_stderr_is_absent: tmux has-session exits 1 both for can't find session: <name> (cmd-find.c) and for no-server (the client.c spellings already modeled). Both are observed absence. dashboard_instance_observe no longer reports an absent service session as an unobservable one; every other nonzero exit still refuses.

Test plan

  • roadmap_dashboard_instance_apply_witness_test dashboard_service_is_named_and_scoped_off_production updated to assert the --release-revision argv. These commits ran on the srv1 lab branch (they are what got the lab dashboard serving); no local interpreter in this session, so CI is the executing evidence here.

🤖 Generated with Claude Code

Brian Searls and others added 2 commits September 15, 2026 03:22
…e service

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot mentioned this pull request Sep 15, 2026
6 tasks
gunbc-ci-auto-heal and others added 3 commits September 15, 2026 14:32
…ashboard ensure.

Actuation no longer collapses has-session to a Bool or rereads HEAD: unknowable sessions refuse before mutation, and serve --release-revision is the revision apply already admitted.

Co-authored-by: Cursor <cursoragent@cursor.com>
The keystone already re-executes its members; folding the new claims into it blew the post-cut eval-step budget while the controls themselves remained cheap as their own identities.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls added this pull request to the merge queue Sep 15, 2026
Bootstrap and ensure-roots pass none instead of an empty CommitSha sentinel; ensure-service consumes Present from apply-after-preflight and no longer validates emptiness at runtime (review 66635).

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot removed this pull request from the merge queue due to a manual request Sep 15, 2026
@gunbai-bot

gunbai-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

review 66635: the empty CommitSha sentinel is gone. dashboard_apply_plan now takes CommitSha?. Apply-after-preflight passes Present with the admitted source revision; bootstrap and ensure-roots pass none because those plans cannot contain DashboardEnsureService. dashboard_ensure_service itself takes a required CommitSha and no longer string-compares emptiness. If ensure-service ever reached a fold that did not admit a revision, that arm refuses before launch.

— sent from quick-lynx-569

@briansrls
briansrls added this pull request to the merge queue Sep 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2026
@briansrls
briansrls added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 8408516 Sep 16, 2026
4 checks passed
@briansrls
briansrls deleted the session/merry-eagle-325-dashboard-apply-fixes branch September 16, 2026 02:27
gunbai-bot Bot pushed a commit that referenced this pull request Sep 16, 2026
Delete the two process_identity_eq admissions consumed at main, drop ensure_service rows whose call sites left with the tmux split, and admit the four TargetChanged rebinds that still resolve through observe.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant