Repository navigation
dashboard apply: serve argv carries --release-revision, and observed tmux absence is absence - #11430
Merged
Merged
Conversation
…e service Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…25-dashboard-apply-fixes
…ashboard ensure. Actuation no longer collapses has-session to a Bool or rereads HEAD: unknowable sessions refuse before mutation, and serve --release-revision is the revision apply already admitted. Co-authored-by: Cursor <cursoragent@cursor.com>
The keystone already re-executes its members; folding the new claims into it blew the post-cut eval-step budget while the controls themselves remained cheap as their own identities. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added this pull request to the merge queue
Sep 15, 2026
Bootstrap and ensure-roots pass none instead of an empty CommitSha sentinel; ensure-service consumes Present from apply-after-preflight and no longer validates emptiness at runtime (review 66635). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
review 66635: the empty — sent from quick-lynx-569 |
briansrls
added this pull request to the merge queue
Sep 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
briansrls
added this pull request to the merge queue
Sep 16, 2026
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
Delete the two process_identity_eq admissions consumed at main, drop ensure_service rows whose call sites left with the tmux split, and admit the four TargetChanged rebinds that still resolve through observe. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes split out of the srv1 lab integration branch (#11396), which is lab-only and must not merge; review 66509 on that PR asked for exactly this split.
What
gunbc.roadmap.roadmap_dashboard_instancedashboard_instance_serve_argvtakes the release revision and emits--release-revision, whichservehas required since Phase A: bind release identity to the serve process, compare it at readiness #7909.roadmap_dashboard_instance_applydashboard_ensure_servicereads it fromgit rev-parse HEADin the instance's repo root before starting the service, and refuses (typed,dashboard_exec_refused) when that read fails or is empty rather than launching a serve that will refuse later.extdeps.tmuxtmux_has_session_stderr_is_absent:tmux has-sessionexits 1 both forcan't find session: <name>(cmd-find.c) and for no-server (the client.c spellings already modeled). Both are observed absence.dashboard_instance_observeno longer reports an absent service session as an unobservable one; every other nonzero exit still refuses.Test plan
roadmap_dashboard_instance_apply_witness_testdashboard_service_is_named_and_scoped_off_productionupdated to assert the--release-revisionargv. These commits ran on the srv1 lab branch (they are what got the lab dashboard serving); no local interpreter in this session, so CI is the executing evidence here.🤖 Generated with Claude Code