Skip to content

onboard deepseek v1 flash - #11377

Closed
briansrls wants to merge 2 commits into
mainfrom
admission/retire-11193-anchor-row
Closed

briansrls wants to merge 2 commits into
mainfrom
admission/retire-11193-anchor-row

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session sunny-carp-329.
Pushing to admission/retire-11193-anchor-row advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 2 commits September 14, 2026 07:53
#11347 landed the three bare-name import fixes, so the transition this row
admitted is now PRESENT AT THE BASE and there is no delta left for it to
admit. A consumed row refuses roster edits and landing (base equals head),
so main's push fails namespace-wave-admission until it goes.

This is the repayment half of the debt #11347's body declared, paid
adjacent to the borrowing rather than deferred: the roster's resting state
is empty, and it is a place rows pass through rather than live.

Deletes the row and the doc paragraphs that described it -- a surviving doc
block above an emptied array would assert a row that no longer exists.
The general commentary on consumed rows and the #11182 relocation
distinction is untouched.

cargo check -p v1-compiler --lib: clean. cargo fmt --all --check: clean.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D2AF1pri3WJkug5AtCYLGF
…ation set alone"

Review 66052, correct and against me. I deleted the doc paragraphs describing
my own row and left the neighbouring ones asserting a population the
declaration no longer carries:

  ":1774"      "What remains below is the #11182 relocation set alone"
  ":1803-1809" "these seven still admit a real delta and deleting them would
               refuse a live transition"

Both are false against `&[]`. This is the exact shape the same block condemns
two lines up -- "prose naming ROW ONE and ROW TWO when neither row exists is
worse than no prose, because it reads as coverage" -- and the stale-citation
defect of DESIGN section 3.

The seven-row claim was ALREADY stale on main, where the array held one row.
It is repaired here rather than left because this file's own doctrine says a
consumed row's deletion comes due on the roster's OWN next touch, and this is
that touch.

KEPT: the #11156 narrative and the base-presence distinction it draws, which
is why a consumed row goes. That reasoning is still true and still the point.

cargo check -p v1-compiler --lib: clean.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D2AF1pri3WJkug5AtCYLGF
@gunbai-bot

gunbai-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Closing: stale auto-opened PR on admission/retire-11193-anchor-row, whose work already landed as #11356 (ba6530c2955). Because that was a squash merge, the branch's commit is not an ancestor of main, so the dashboard re-opened a PR from it.

It carries nothing main lacks and would be a large revert: the branch is 16 commits behind, and against current main it differs by 141 files / 12,242 deletions — including 237 lines this file has gained on main since #11356 landed. None of that is a change anyone authored here.

The admission row it was written to delete is already gone: namespace_wave_admission.rs on main reads NAMESPACE_TRANSITION_ADMISSIONS: &[TransitionAdmission] = &[], its documented resting state.

Deleting the branch so this does not re-open a third time. This is the second instance of the shape today (#11348 was the first) — a squash-merged branch re-proposed against a moved main looks exactly like a catastrophic revert, and it arrives wearing the original work's title.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D2AF1pri3WJkug5AtCYLGF

@gunbai-bot gunbai-bot Bot closed this Sep 14, 2026
@gunbai-bot
gunbai-bot Bot deleted the admission/retire-11193-anchor-row branch September 14, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant