Repository navigation
gunbc-private-direction - #11361
Closed
gunbai-bot[bot] wants to merge 16 commits into
Closed
gunbc-private-direction#11361gunbai-bot[bot] wants to merge 16 commits into
gunbai-bot[bot] wants to merge 16 commits into
Conversation
…xpressible without treating ListingGone as a delete. The arm writes DerivedField only, refuses while the listing is still projected or standing is not ListingGone, and never touches judgement or drops the row. Co-authored-by: Cursor <cursoragent@cursor.com>
…ular scaffold. Preconditions lived in the DerivedField arm, so a schema with no derived columns could converge on a refused request. classify_review_sheet already consumes the three-arg fold; a frontier whose trigger was "bind this function" did not name a later change. Co-authored-by: Cursor <cursoragent@cursor.com>
…e refuses at the identity cell. The door was only reachable from tests and a zero-erasure wrapper. Ensure is the operator path; empty erasures remain the no-erasure pass. Row-grained ErasureRefused now names the identity A1, matching located write-or-refuse. Co-authored-by: Cursor <cursoragent@cursor.com>
…cells record an erasure. A later projection that re-emits the same listing id would otherwise rewrite title and flip standing with no diagnostic. Gone rows that still carry derived text still restore; that is a scrape gap, not an erasure. Co-authored-by: Cursor <cursoragent@cursor.com>
…g durability. An authorized request with no derived columns is a located refuse, not Converged. Gone-plus-empty cells are not an erasure record; the caller must re-supply the erasure list each pass. Co-authored-by: Cursor <cursoragent@cursor.com>
…an read. Empty derived cells are not an erasure record. The authorized pass writes DerivedErasureMark, and a later pass that would restore title from the projection keeps those cells blank because it reads that mark. Co-authored-by: Cursor <cursoragent@cursor.com>
Applied is a readable label; blank is the unmarked cell. Column lookup goes through first_column_of_kind so each ReviewColumnKind is not its own filter copy. Co-authored-by: Cursor <cursoragent@cursor.com>
Kind selection is now a keep over ReviewColumnKind. Schema-missing vs header-missing are distinct ObservedKindCell arms, and the identity-split deferral is a Scaffold bind instead of a comment. Co-authored-by: Cursor <cursoragent@cursor.com>
Kind membership is exhaustive match that yields a column or a refuse arm, so the Bool keep helpers (and the keep-parameter fold) are gone. Co-authored-by: Cursor <cursoragent@cursor.com>
Operator names are filter then map again; listing identity is listing_id, not a no-op scaffold bind. Co-authored-by: Cursor <cursoragent@cursor.com>
Erasures are a parameter of classify, not a second name. Column lookup shares first_column_where; take is exhaustive match, not a Bool kind predicate. Co-authored-by: Cursor <cursoragent@cursor.com>
Authorize already matches ObservedKindCell for schema-absent vs header-missing; a ListingStandingRead? wrapper had no call site and collapsed those causes. Co-authored-by: Cursor <cursoragent@cursor.com>
Conflict markers were left in append_cell_for_column; keep parent skip of operator columns and the door's blank DerivedErasureMark, and restore columns_by_name so classify/append still resolve. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Closing: this is a duplicate of #11097 on the identical head This one is not merely redundant, it is harmful: two PRs on one commit duplicate the required check contexts, which is why #11097 was reading BLOCKED with doubled — sent from quick-ibex-468 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
quick-ibex-468.Pushing to
pr11097advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan