Repository navigation
SCM dashboard workers - #11328
Closed
gunbai-bot[bot] wants to merge 5 commits into
Closed
SCM dashboard workers#11328gunbai-bot[bot] wants to merge 5 commits into
gunbai-bot[bot] wants to merge 5 commits into
Conversation
git_use_covers_import took (row, module_name, imported_module) and its only caller — the index fold — passed the row's own owner and target straight back in. Two of its three conjuncts therefore compared a value to itself, and its surface match re-derived what the caller had already destructured, so the only conjunct that could fail at the one site that ran it was the role/authorization check. A conjunct that cannot fail where it is called is not a weaker wall; it is a decoration that later reads as coverage (DESIGN 4b). Replaced by git_use_row_admits_its_import(row), which asks the discriminating question and nothing else. Module/target is what the index is KEYED by, and membership is already git_import_authorized's job, so nothing is lost and one authority stops being restated at two grains. Found by review 65735. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Qy8ErCHX3Npuvd6P7RPe3
The coverage note said the remaining live-use population was unknown. That is true for Rust uses and for configured .dag process invocations, which have no producer that enumerates them. It was false for ParsedDagGitDependency -- the one surface this policy actually covers -- whose population is derivable from the same import fact the policy consumes. Calling a derivable number unknown understates what is already in hand, and it is the reading a later lane would have trusted. Read at this revision: 217 non-fixture modules import extdeps.git/github directly, 34 of them inside dag/extdeps (authority side), so 183 consumer-side uses against 2 enrolled rows. Recorded as a transcribed reading with its derivation named, and explicitly not an oracle: no entry point re-derives it, so it rots (DESIGN 6). Standing up that producer is the first obligation of the census-completion lane. Also records a positive result: zero modules under dag/gunbc/scm/ carry a direct extdeps.git or extdeps.github import at this revision -- the wall's own subject, measured clean, and silent about the configured-process bypass no import fact can see. Found by review 65752. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Qy8ErCHX3Npuvd6P7RPe3
Contributor
Author
|
Accidental duplicate, same cause as #11324: a local working-branch name in my worktree got auto-pushed and the dashboard opened a PR from it. Head is the identical commit (9ed67b8) as #11317, where all the work and review history live. Closing; I have switched to working on the PR's own branch so this stops recurring. — sent from still-bat-15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
still-bat-15.Pushing to
fix11317advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan