Repository navigation
Model runner depriv and deliver the unit fragment - #11309
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
…agment. The hand-placed depriv.conf was the unread override that made fragment delivery accidental. The drop-in is now derived from the unit-user/job-user split, the CI sccache instance, and Docker's rootless endpoint; runner-host-file converge writes that drop-in and the modeled fragment together. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depriv.confcarried: systemdUser=fromDeployRunnerPrincipal.unit_user,CTRL_RUNNER_JOB_USERfromRunnerHostDeploy.job_user, CI sccache env fromci_cache_instance,DOCKER_HOSTfromextdeps.docker.endpointdocker_rootless_unix_endpoint.TranscribedUncited(read obligation:id -uof the job user). It is notfleet_posix_ci_runner_user.uid, which is recorded as the wrong number.runner_host_file_convergenow delivers four files per host: the modeled fragment, the modeled depriv drop-in, the teardown drop-in, and the needrestart deferral. The fragment still namesdeploy.runner_user, not root, so a missing depriv drop-in cannot run job code as root.BorrowerHeldCooperativeHostFifo. Stacked on Fleet permit-scope observer over the one systemctl-show transport #11279.Test plan
test.claim.runner_unit_file_witness_testandtest.claim.runner_host_file_converge_witness_test/etcpaths; srv9 refusesUser=briansrlsMade with Cursor