Repository navigation
Retire runner identity admissions after #11177 merges - #11262
Merged
gunbai-bot[bot] merged 1 commit intoSep 16, 2026
Merged
Conversation
briansrls
marked this pull request as ready for review
September 14, 2026 16:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
#11177 is on main, so the process_identity_eq relocation is present at the base and both TargetChanged rows report consumed; the roster returns to empty. Rebuilt from main rather than merged forward: the stacked branch had drifted into a revert of the PR it followed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qc3VJ9KnBA7aXp2ZQjCwTq
gunbai-bot
Bot
force-pushed
the
followup/runner-canary-admission-retirement
branch
from
September 16, 2026 03:13
e7f21d7 to
b6c110f
Compare
gunbai-bot
Bot
deleted the
followup/runner-canary-admission-retirement
branch
September 16, 2026 05:27
briansrls
pushed a commit
that referenced
this pull request
Sep 16, 2026
namespace_wave_admission.rs: main retired the two consumed gunbc#11177 rows (#11262); kept main's dissolution note and emptied array, re-added only this branch's sixty-six gunbc#11461 rows - zero deletions of main's lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes exactly the two namespace transition admissions introduced by #11177 for
gunbc.runner_connectivity_recoverycalls toprocess_identity_eq:decide_wedged_runner_connectivity_actionandverify_incarnation_replace_postcondition, both resolving togunbc.build_cache_instance. Retains the relocation witnesses and all three live-evidence frontiers.This draft is based on
session/smart-wolf-362atd066c789b35so its diff contains only the deletion and the dissolution sentence. Do not land before #11177 merges. Its merge is the consuming event; after that, retarget this PR to main and preserve unrelated main roster entries during integration. No consumption is claimed to have happened yet.Authority: fierce-lark-661 adjudication message
msg_3ddc334b, relayed with the exact row set by royal-eagle-761 inmsg_62db8138-b5ed-4adf-9721-1ef46daadf8c. Thegunbc.v1_maintenance_standingruling permits a measured namespace delta as a consumed ledger entry provided its deletion follow-up exists before enqueue and subsequently lands. It does not permit permanent admission behavior.Validation: exact two-row diff inspected;
git diff --checkandcargo fmt --all --checkpass. No runtime logic or witness changes. Post-merge integration and CI remain required. Hold both heads pending the serialized landing sequence and currency ruling.CI state: zero CI runs, not pending. This draft targets
session/smart-wolf-362; required CI triggers on a main base, and draft auto-coverage is also disabled. Local formatting/diff checks are not required-lane validation.Required landing sequence (parent ruling): #11177 merges -> retarget #11262 base to
main-> let ONE CI run COMPLETE -> flip out of draft -> ask royal-eagle-761 with the facts at that SHA. Notify royal-eagle-761 when retargeting. Do not retarget before #11177 merges: the current stacked base expresses the real dependency, and retargeting early would include the parent's implementation in this diff.At the main integration, preserve main's entire namespace roster and remove only the two exact #11177 admissions; verify zero unrelated deletions and
git merge-tree --write-tree origin/main HEAD. If draft gating leaves CI unstarted after retargeting, report that actual state and use an explicitly authorized manual trigger; zero checks is not a completed run. Do not change the ordered requirement by marking ready before the required run completes.The merge ask must carry the exact head SHA, current-head approvals, open REQUEST_CHANGES, failed artifact count, running review count, required CI outcomes, and GitHub merge admission. Neither this draft's existence nor checks on the parent count as execution evidence for the deletion. Both heads remain held pending their respective sequencing and currency rulings.
Stack refreshed at
e7f21d7f9c3against parentd066c789b35: the only diff remains the two admission deletions and dissolution wording (one file). Formatting, diff checks, and merge-tree against the parent branch pass. This is not main-base CI validation; the draft still waits for #11177 to merge before retargeting.The parent has retired the consumed #11193 admission; this draft preserves that retirement. Only the two #11177 rows and their retirement wording differ.