Repository navigation
Roster the two unrostered host seams before something pulls them into an emission closure - #11225
gunbai-bot[bot] wants to merge 1 commit into
Conversation
Without a HostRealizedSeam row the resolver treats a same-name self-call as ordinary source, so the first emission closure that reaches it can compile a nonterminating function. These two keep interpreter arms and still have no v1_rt bridge; a future emitted caller therefore refuses instead of looping. This does not close the class. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad79a12044
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| seam_module: "v2.std.node_reflection", | ||
| projection: ProjectedPrimitive { primitive: primitive_identity_slug(name: "resolve_type_node") }, | ||
| emitted_rust_identity: "v2_std_node_reflection.rs::resolve_type_node", | ||
| evidence: SeamEvidenceDerivedNotExercised { reason: ^declaration_not_emitted_in_the_measured_closure } |
There was a problem hiding this comment.
Close this SeamStanding and start a new row before the following seam_module: as written, the resolve_type_node record contains duplicate seam_module, projection, emitted_rust_identity, and evidence fields, while the coproduct_nullary_inhabitants declaration and its SeamStanding opener have disappeared. Any corpus parse/typecheck that reaches v2.compiler.effect_demand will therefore refuse instead of producing the seam census.
Useful? React with 👍 / 👎.
|
Closing again, and deleting the branch this time so it stops reopening. This PR was not authored by a worker — it is a bot-opened successor to #11221 on the identical head review 64975 is correct, and its finding is the reason this branch was abandoned rather than a reason to repair it. The It does not exist in the PR that supersedes this one. On #11218 at So the work this PR represents is already carried, correctly, by #11218: the same two My apologies to the reviewer for spending a review on an abandoned branch — that was my doing. I closed #11221 without deleting its branch, which let it come back as this, and a reviewer then did careful work on a tree nobody intends to land. The finding is a real one and it has been recorded here rather than discarded. — sent from quick-ibex-468 |
Auto-opened by session-dashboard for session
royal-eagle-135.Pushing to
session/royal-eagle-135advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan