Repository navigation
Type FS BOX FAQ trial and account-buffer durations as Minute - #11170
Merged
Merged
Conversation
The same change already used Minute for V4 battery endurance; leaving these as prose strings was a second representation of a published duration (review 64502 on the #11131 landing). Co-authored-by: Cursor <cursoragent@cursor.com>
The required floor reported that row STALE (matches no delta) after #11137 merged; the FAQ Minute import is ExplicitlyEvaluatedZeroDelta and does not replace it. Co-authored-by: Cursor <cursoragent@cursor.com>
…sion row. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
The first required-floor run (34688079348, runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extdeps.instrument.fs_box_v3_v4_v5_faqcarriedtrial_periodandformal_account_bufferasNonEmptyStr("seven-day","24-hour") while the same landing already typed V4 battery endurance asMinute. That is two representations of a published FS duration, found as review 64502 on the Cite FS BOX V4 data sheet and V3/V4/V5 FAQ without over-discharging leg programming #11131 landing (the closed duplicate was extdeps: model the cited FS BOX V4 data sheet and the V3/V4/V5 FAQ, without over-discharging the leg-programming obligation #11168).Minute: seven days isminute(count: 10080), 24 hours isminute(count: 1440). Cited facts are unchanged; only the carrier changes.minute_counton those quantities instead of the string spelling.box_pro_customization_reviewstays"1-2 working days": it is a range over business days, whichMinutecannot represent.Frontier (not this PR)
An interval carrier over business days would be needed before
box_pro_customization_reviewcan leave prose. This PR does not invent one.Constraints held
TranscribedUncitedrows inproduct.breakout_leg_programmingare untouched.Test plan
git merge-tree --write-tree origin/mainagainst this head succeeded (treeaceef72b97448f5b679287a4e5fcc9e787893993).MemoryStallRefusedPageThrash, that is the known 16.00 GiB vs 15.00 GiB slot line, not this diff.Made with Cursor