Skip to content

A refusal that claimed admission passed when nothing evaluated it #11139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 1 commit into from
Sep 12, 2026
Merged

A refusal that claimed admission passed when nothing evaluated it #11139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dag/gunbc/harness/harness_seat.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,10 +455,18 @@ fn harness_no_candidate(acc: HarnessCandidates, note: String, retryable: Bool) -
// route satisfies what the demand asked for -- and keeps the offer and the demand comparable by the
// equality the fabric uses.
//
// AND THE REFUSAL SAYS THAT ADMISSION WAS NOT EVALUATED, NOT THAT IT PASSED. The sentence here once
// read "the serving offer bound and its route is admissible", which outran its own execution: this
// branch never calls spark_first_party_admission, so nothing evaluated provider-use admission for
// this turn, and a reader -- including one reporting upward, which is how it reached the operator --
// could take a producer's EXISTENCE for a producer having RUN. That distinction is the whole subject
// of this arm, so the wording carries it: admission cannot yet be evaluated, and the producer exists
// and has not run (operator-routed review of #11083).
//
// Restoration trigger: a launch receipt that reads the weights, tokenizer and runtime closure off a
// running engine, SUFFICIENT FOR gunbc.serving.turn_demand serving_turn_work to return TurnWorkBound
// for a harness turn -- at which point the demand and work identities exist, the admission producer
// above is called with them, and bind_candidate has everything it compares.
// is called with them, and bind_candidate has everything it compares.
fn harness_bind_candidate(acc: HarnessCandidates, group: FabricGroup, endpoint: ServingRouteEndpoint, launch: VllmEndpointProcessLaunch, standing: HarnessBackendStanding, requirement: ServingModelRequirement, seats: Nat, now: EpochSecs) -> HarnessCandidates {
match bind_spark_serving_offer(
principal: "gunbc" as NonEmptyStr,
Expand All @@ -478,7 +486,7 @@ fn harness_bind_candidate(acc: HarnessCandidates, group: FabricGroup, endpoint:
acc: acc,
note: seat_bind_detail(
group: group,
text: "the serving offer bound and its route is admissible, but a serving turn has no Work identity: nothing observes the weights, tokenizer and runtime closure a launch loaded, so gunbc.serving.turn_demand cannot bind a source manifest and product.fabric.selection bind_candidate has no work to compare the permit against",
text: "The serving offer bound. Provider-use admission cannot yet be evaluated for this turn because its exact Work identity is unestablished: nothing observes the weights, tokenizer and runtime closure a launch loaded, so gunbc.serving.turn_demand cannot bind a source manifest, and product.fabric.selection bind_candidate has no work to compare a permit against. gunbc.spark.first_party_serving spark_first_party_admission EXISTS and has NOT RUN for this turn",
),
retryable: false,
)
Expand Down
Loading