Repository navigation
DSV41-6b take over #11096 (sshpass runner convergence) after session archive; fix review 64038 - #11122
DSV41-6b take over #11096 (sshpass runner convergence) after session archive; fix review 64038#11122briansrls wants to merge 8 commits into
Conversation
…y String. Review 64038: the failing diagnostic must name why a tool is unobserved, and apt_package_of_witness_test's witness_note is an annotation, not program data. The dispatch-mode count follows the twentieth mode so the witness lane is not vacuously red, and the receipt uploads on failure because FailFast never cats it. Co-authored-by: Cursor <cursoragent@cursor.com>
They are uncommitted session probes, not consumers of the convergence model. Leave them on disk; do not hand-edit the generated gitignore. Co-authored-by: Cursor <cursoragent@cursor.com>
A hand-updated count against the live roster is a change detector: bumping N when a mode is added collapses the assertion to measure() == measure(). The new mode must be on the roster, wires must be unique, and options join the roster both ways. Co-authored-by: Cursor <cursoragent@cursor.com>
posix_command_v_check_argv is not a PortableRemoteWord vector, so the password-session ensure refused before contacting srv4. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
version_ok would otherwise stay Unobserved after a present probe. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e27ab3acf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match prepare_fleet_ssh_agent_context( | ||
| attempt_raw: runner_password_session_tool_converge_attempt_raw, | ||
| ) { | ||
| FleetSshContextRefused { cause: c } => exit_failure(reason: c) |
There was a problem hiding this comment.
When prepare_fleet_ssh_agent_context refuses—for example because the agent selector or known-hosts anchor cannot be materialized—this arm exits before creating target/runner-password-session-tool-converge-receipt.txt. The emitted workflow nevertheless runs the receipt upload with always() and if-no-files-found: error, so precisely this failure path produces no diagnostic artifact and replaces it with an additional missing-file upload failure. Write the refusal body to the receipt before returning, as is already done for tool-outcome failures.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing as a duplicate: this is the dashboard's auto-opened PR on the session branch, and its DSV41-6b content landed as #11096 (merged, ea08225). The only delta between this head and the merged head 2704b51 is the re-addition of src/v2/test/claim/manual/dsv41_6_probe.dag and dsv41_6b_probe.dag, which #11096's own commit 7e89e4d deliberately removed as uncommitted session scaffolds with no consumer (DESIGN §3c/§6). That is exactly what review 64231 found, and the right answer is not to land them. The branch is also far behind main. Nothing here is lost. — sent from sunny-carp-329 |
1 participant
Auto-opened by session-dashboard for session
cool-pike-654.Pushing to
session/cool-pike-654-dsv41-6badvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan