Skip to content

Delete unread dag_formal_productions (second dag grammar statement) - #11102

Merged
gunbai-bot[bot] merged 1 commit into
mainfrom
session/sharp-tern-402-formal-catalog-cut
Sep 11, 2026
Merged

gunbai-bot[bot] merged 1 commit into
mainfrom
session/sharp-tern-402-formal-catalog-cut

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • After D5 (D5: parse keyword field-init, as-cast, match-as-infix, unary minus, string map keys, and return #11058): delete dag_formal_productions() in src/v2/extdeps/languages/dag.dag. It had no readers; the executing grammar is the dag_grammar_* combinators.
  • Keeps FormalProduction and the consumed catalogs (dag_type_decl_structural_formal_productions, fixture dag_formal_production_fn_* rows).
  • Drops the unused grammar_formal_terminal_lexeme import that only the deleted roster used.
  • required-regen first_generation_equal (155/155); only declared-divergent main.rs.

review 63918 finding 2 / work item adhoc-57ff15a5-52e. dag.dag is a closure member — srv2 receipt is parent's.

Test plan

  • git grep dag_formal_productions is empty after the cut.
  • required-regen 155/155 first_generation_equal.
  • Parent srv2 closure receipt (digest expected to change; after-set identical).

Made with Cursor

… grammar.

Combinators remain the executing grammar. FormalProduction stays for consumed grammar-relation rows. required-regen first_generation_equal 155/155.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

srv2 closure receipt at 304b9a6 (this head overlaid on main bdf9823, producer built from the overlay, native fold over the 167-module closure of src/v2/compiler/00_compile.dag):

  • native emit + build: EXIT=0, 172 files emitted, closure 44326895….
  • refusal after-set: 14 rows, identical row-for-row to the main baseline at bdf9823 (13 parse_g0_tokens_remain + 1 normalize_reason_post_normalize_not_well_formed on src/v2/std/runtime.dag). Regressed: none. Fixed: none.
  • closure manifest: identical to main's (167 modules).

Deleting the unread dag_formal_productions from src/v2/extdeps/languages/dag.dag is closure-neutral on the emitted compiler. Instrument: closure_pr.sh 11102 on srv2; runs/closure_pr_11102_b.out, p-11102/refusals_after.txt.

— sent from eager-raven-113

@gunbai-bot
gunbai-bot Bot merged commit bc083ca into main Sep 11, 2026
4 checks passed
@gunbai-bot
gunbai-bot Bot deleted the session/sharp-tern-402-formal-catalog-cut branch September 11, 2026 23:49
@briansrls
briansrls restored the session/sharp-tern-402-formal-catalog-cut branch September 11, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants