Skip to content

extdeps.memory.sk_hynix: catalog row for HMA82GR7CJR8N-VK from manufacturer authority - #11081

Closed
gunbai-bot[bot] wants to merge 3 commits into
mainfrom
session/bright-dove-400
Closed

gunbai-bot[bot] wants to merge 3 commits into
mainfrom
session/bright-dove-400

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session bright-dove-400.
Pushing to session/bright-dove-400 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

gunbc-ci-auto-heal and others added 3 commits September 11, 2026 16:42
The catalog row is an upstream part SK hynix sells; Rev. 1.7 / Aug.2019 Ordering Information lists HMA82GR7CJR8N-VK as 16GB 2Gx72 2Rx8 RDIMM, not a local boot-log reading.

Co-authored-by: Cursor <cursoragent@cursor.com>
Adding extdeps_model_scope without leaving the legacy manifest left the declaration unenrolled. The C-die datasheet is a further citation, not the module-wide first, because it does not list the AFR rows this file already carries.

Co-authored-by: Cursor <cursoragent@cursor.com>
Module-scope citations attest the declared AFR subject; the Rev. 1.7 datasheet does not list those parts, so it moves to FactCitation. A witness inhabits the new row as a MemoryPopulationRow so the catalog is not a dangling declaration.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls marked this pull request as ready for review September 11, 2026 18:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-11T19:13:44.421164Z 7e66e58 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gunbai-bot

gunbai-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Closing as a stale duplicate of #11066, which merged this same work at 2026-09-11T18:26:24Z.

Verified rather than assumed, on both files this PR touches:

comm -23 <(git show pr11081:<file> | sed "s/^[[:space:]]*//" | sort -u) \
         <(git show origin/main:<file> | sed "s/^[[:space:]]*//" | sort -u)

returns empty for dag/extdeps/memory/sk_hynix.dag and
dag/test/claim/sk_hynix_dram_module_witness_test.dag — every line here is
already in main. hma82gr7cjr8n_vk_catalog, hma82gr7cjr8n_vk_catalog_citation
and c_die_rdimm_datasheet_rev_1_7 all resolve on main today. The +117 in the
diffstat is an older merge base, not new content, which is why this sits at
mergeStateStatus BLOCKED.

The originating session (bright-dove-400) is archived and its work item closed
on #11066's merge, so there was nobody to ask — I checked the content instead of
closing on the title matching. Reopen if I am wrong about that: a second PR
on the same branch after a merge is exactly the shape where a real follow-up fix
gets mistaken for a duplicate, and I would rather be corrected than have
something real dropped.

The row itself is doing its job: it unblocks a capacity join in #10965 that could
not be written while one of Mt. Collins unit 1's three installed parts had no
catalog row.

— sent from eager-owl-205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants