Repository navigation
Route cancel-in-progress through github_event_name_equals (review 63766) - #11052
Merged
Merged
Conversation
…e gha_* nicknames. The concat template and LogicalAnd/Or/NotEquals wrappers were a second spelling of constructors this module already imported; interpolate of the structural form keeps witnesses.yml byte-identical to 608c9ad. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Duplicate of #11049 now that session/sharp-tern-402 is rebased onto main with the same 63766 follow-up. |
Contributor
Author
|
Reopened: 63766 lands here off main, not on the merged #10981 session branch. |
3 of 4 tasks
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Sep 15, 2026
…nded sha The merge queue runs the required floor on its COMPOSED revision, and that revision is the one that lands -- measured, not assumed: the merge_group runs whose head_sha is 4f30460 and fe85902 are the commits main carries afterwards. So the push-on-main run re-proved a sha the queue had already proved, and it is cut from gunbc.witness_floor_workflow witness_floor_triggers. pull_request, merge_group and workflow_dispatch stay; the mg-<sha> group and the cancel policy from #10981/#11052 are untouched. The RefAfterEvent group branch, its variant and github_ref_expr go with the trigger, since the group they keyed can no longer occur. Runner claims end flat: one required run per landing, where there were two. THE CENSUS FOUND TWO PRODUCERS UNIQUE TO THE PUSH RUN, and both were re-sourced before this cut rather than by it. Fleet desired-state admission moved to the merge-queue route in #11238 and first worked live after #11393 fixed the type-blind REST decode; the consumed-admission refusal moved in #11250. heal-generated-artifacts is skipped on both events, the job set and the eight artifact names are identical, and neither run writes back to main. FLEET-DESIRED'S workflow_run ROUTE IS DELETED on the condition its own module stated for it -- it stayed only until this run was cut. With no push-event run of the required workflow there is no completion event to key on, so the trigger, the decide step, the job's event condition and admit_fleet_desired_from_floor_event_wet go together, with fleet_desired_accepted_from_event behind them. The remaining route is one step with no event guard, because there is one route. THE WITNESSES ARE RE-AIMED, NOT DROPPED. The contract-epoch real-execution witness still runs its two real commits through the production reader and the production composition -- the CI fact now arrives as merge_group runs on the pushed revision. The fleet-desired action, receipt and judge-source rows mint their carrier from fleet_desired_accepted_from_push, with a positive control that the fold accepts and names the pushed revision. Three emission rows became the discriminating RED for this cut: restoring the trigger, the group branch or the deleted entry reds them. gunbc.rung_drop main_per_commit_floor_verdict IS RETIRED BY ITS OWN TRIGGER. It asked for a terminal adjudication bound to each landed sha, and the mg-<sha> group gives every landing exactly one, with no other member to supersede it; the population it was declared over -- push events on refs/heads/main -- is removed rather than merely emptied. NOT IN THIS CHANGE, AND NAMED RATHER THAN LEFT TO BE FOUND: gunbc.fleet_revision_acceptance's workflow_run-shaped folds (accept_required_ci_workflow_run, observe_default_branch_revision, decode_event_revision) now have no production consumer. Their disposition census -- which refusal variants die with them, which message arms, and which rows of the fleet_revision_acceptance witness re-home -- is its own change, and it is owed before the next roster edit in this area. Operator sign-off for the job-roster change is cited in this lane's brief. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
608c9ad5, before review 63766's two findings landed.cancel_in_progress_of_policyinterpolatesgithub_event_name_equalsinstead of a concat template; the four-cell witness retests against that structural form.gha_and/gha_or/gha_not_equalsand constructsLogicalAnd/LogicalOr/NotEqualsat the group-expression sites. Keepsgithub_event_name_equalsandgha_format_prefix.608c9ad5witnesses.yml; livecancel-in-progressremainsfalse; committed YAML is unchanged.Test plan
claim_batchw_running_cancel_four_cell_through_the_producer(cpu=2ms)claim_batchw_emitted_group_expression_names_each_event_branch(cpu=6ms)witness_floor_concurrency_groupstring equals the608c9ad5workflowgroup:lineMade with Cursor