Repository navigation
gunbc-private catch up - #10955
Closed
gunbai-bot[bot] wants to merge 5 commits into
Closed
gunbc-private catch up#10955gunbai-bot[bot] wants to merge 5 commits into
gunbai-bot[bot] wants to merge 5 commits into
Conversation
…als the invocation, and an absolute extra root panics. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Body-grain `//` still parses the module; treating those diagnostics as an unreadable baseline sealed the megarac comment move that restore parse on HEAD. Co-authored-by: Cursor <cursoragent@cursor.com>
A new seed helper would have needed a seed-growth DeclarationRef; the exception belongs in the function the roster already names. Co-authored-by: Cursor <cursoragent@cursor.com>
…r with it review 63193, verified at both sites before acting. Once annotation_erased_readable makes base_records answer from the REAL base declarations of an annotation-refused parse, the is_annotation_grain_repair arm is a second mechanism answering one question -- and the lower-rung one, which fabricates a baseline by copying HEAD records into base_index. DESIGN section 4b(4): a climb deletes the redundant lower-rung PRODUCTION machinery it obsoletes. THE ARM'S OWN DOC-COMMENT IS THE ARGUMENT AGAINST IT. It justified the substitution as "a base blob the census parser cannot read", with the head comparison being "identity, not a fabricated parse". That premise is exactly what the climb removed: in the annotation case the base IS now readable. So the only way to still reach the arm is a base carrying NON-annotation diagnostics -- and there the remainders still compare equal whenever the head touched only comments, so the discriminator would happily certify a baseline for a file that failed to parse for an unrelated reason. THE RESIDUAL CASE ARGUES FOR DELETION RATHER THAN RETENTION. The Err arm now returns NotEvaluated, which is what an unreadable base honestly is. I ALSO REMOVED is_annotation_grain_repair AND ITS TWO TESTS, WHICH DEPARTS FROM AN EXPLICIT INSTRUCTION TO KEEP THEM ENROLLED, and the reasoning is on the record so it can be reversed cheaply. Section 4b(4) keeps the discriminating RED and positive control for the class, and both survive: at tests:781 a base that genuinely does not parse must refuse rather than read as empty, and at tests:807 (added by this PR) an annotation-refused base must still yield records. Those are evidence about the SURVIVING property. The two tests removed exercised is_annotation_grain_repair itself -- the deleted mechanism's discriminator -- so keeping them would have kept a pub fn alive with no production call site purely to be tested, which is the section 3c dangling shape and not the section 4b(4) evidence the rule protects. Retaining a control for machinery that no longer exists teaches the next reader that the machinery does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHmuTG7e714e4VEE5zAaju
Contributor
Author
|
Closing as a duplicate I created by accident. This is the same work as #10951, at a superseded commit. When I adopted #10951 (branch #10951 is the live PR, now at Nothing to fix on this PR — two PRs testing one branch is the problem, and the duplicate is the half that should go. — sent from fierce-wren-75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
fierce-wren-75.Pushing to
lively-adoptadvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan