Repository navigation
gunbc-private readiness - #10905
Closed
briansrls wants to merge 12 commits into
Closed
gunbc-private readiness#10905briansrls wants to merge 12 commits into
briansrls wants to merge 12 commits into
Conversation
gunbc.runner.runner_host_filtered_egress merged to main citing gunbc.runner.runner_guest_egress_attempt, which did not. That receipt and two siblings -- the cgroup placement and guest network observations -- were stranded on a sibling PR that never merged, so main carried a citation naming a module the repository does not contain. That is the positional-reference failure in its worst form. A stale line number decays quietly; a citation to an absent module means a reader cannot find what was cited at all, and the claim resting on it becomes uncheckable. They matter to what landed. runner_host_filtered_egress rejects the bridged topology, and the record of that bridge being tried, what it exposed and why it was abandoned lives in runner_guest_egress_attempt. Without it the rejection reads as a preference rather than a finding. Cherry-picked onto current main rather than resurrecting the stale branch, which is hundreds of files behind and carries the same foreign PCI-identity content this lane just removed from its own PR. Taking the six files leaves all of that behind. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The three modules #10818 added were still dangling: the citing sites named them only in comments, which DESIGN 4c erases, so they were neither citations nor consumers. Fold the attempt, placement, and guest-network facts into the modules that already depended on them, carry typed DeclarationRefs, and file the class on the 4b ledgers. Co-authored-by: Cursor <cursoragent@cursor.com>
…sses The stranded receipts still carried byte quantities as Int and four findings as String commentary. They now consume std.measure, hold those findings as typed carriers beside PlacementDefect, and each newly discovered class has its own 4b row rather than living only inside a per-attempt receipt. Co-authored-by: Cursor <cursoragent@cursor.com>
bridge_readback_defect, guest_tap_retired and corrected_claim were the same 4c class as finding 3 — withdrawn and corrected rulings held as NonEmptyStr after this PR had already established typed carriers beside them. Co-authored-by: Cursor <cursoragent@cursor.com>
The two consumer modules were matching the same coproduct under two names, so the consumption witness counted one fact twice. One fold, imported; the witness asserts it once. Co-authored-by: Cursor <cursoragent@cursor.com>
…he receipts GuestReachability was restating IPv4, prefix, and MAC as strings; those already live in extdeps.network. A sweep of the other added scalars put evidence paths on FilePath, fixture digests on Sha256Digest, guest arch on Architecture, link speed on Bandwidth, and pids on Nat, instead of waiting for the next one-field review round. Co-authored-by: Cursor <cursoragent@cursor.com>
A record that carried empty: true beside procs_at_retirement: "empty", and a member list that restated placement_verdict.pid as prose, could disagree with nothing refusing. Derive the members from the verdict, drop the redundant retirement string, one CpuBoundStanding on the attempt, and inhabit IEEE duplex and Linux NUD instead of leaving those as untracked strings. Co-authored-by: Cursor <cursoragent@cursor.com>
The floor was FloorClean and the consumption witness passed; adjudication refused on namespace-wave-admission with exactly two unadjudicated deltas — cpu_bound_standing rebinding CpuBoundStanding and CpuBoundInterfacePresent onto the attempt module. Those rows dissolve when this PR merges. Co-authored-by: Cursor <cursoragent@cursor.com>
A receipt of observed constants cannot make that test red except by editing the receipt. Imports and folds are the consumption claim; the stall no longer cites the deleted witness as coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/v1/stage0/src/namespace_wave_admission.rs
Contributor
|
Closing: this PR was auto-opened by the session-dashboard from a local working branch name, at head baa03a7 — before the fix it is named for was committed. It carries no delta of its own. The actual fix is pushed to — sent from merry-bear-25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
merry-bear-25.Pushing to
fix-10818-consumedadvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan