Repository navigation
Take over #10818 from a dead lane: three dangling modules cited only in annotation prose, plus typed carriers and 4b ledger rows - #10902
gunbai-bot[bot] wants to merge 12 commits into
Conversation
gunbc.runner.runner_host_filtered_egress merged to main citing gunbc.runner.runner_guest_egress_attempt, which did not. That receipt and two siblings -- the cgroup placement and guest network observations -- were stranded on a sibling PR that never merged, so main carried a citation naming a module the repository does not contain. That is the positional-reference failure in its worst form. A stale line number decays quietly; a citation to an absent module means a reader cannot find what was cited at all, and the claim resting on it becomes uncheckable. They matter to what landed. runner_host_filtered_egress rejects the bridged topology, and the record of that bridge being tried, what it exposed and why it was abandoned lives in runner_guest_egress_attempt. Without it the rejection reads as a preference rather than a finding. Cherry-picked onto current main rather than resurrecting the stale branch, which is hundreds of files behind and carries the same foreign PCI-identity content this lane just removed from its own PR. Taking the six files leaves all of that behind. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The three modules #10818 added were still dangling: the citing sites named them only in comments, which DESIGN 4c erases, so they were neither citations nor consumers. Fold the attempt, placement, and guest-network facts into the modules that already depended on them, carry typed DeclarationRefs, and file the class on the 4b ledgers. Co-authored-by: Cursor <cursoragent@cursor.com>
…sses The stranded receipts still carried byte quantities as Int and four findings as String commentary. They now consume std.measure, hold those findings as typed carriers beside PlacementDefect, and each newly discovered class has its own 4b row rather than living only inside a per-attempt receipt. Co-authored-by: Cursor <cursoragent@cursor.com>
bridge_readback_defect, guest_tap_retired and corrected_claim were the same 4c class as finding 3 — withdrawn and corrected rulings held as NonEmptyStr after this PR had already established typed carriers beside them. Co-authored-by: Cursor <cursoragent@cursor.com>
The two consumer modules were matching the same coproduct under two names, so the consumption witness counted one fact twice. One fold, imported; the witness asserts it once. Co-authored-by: Cursor <cursoragent@cursor.com>
…he receipts GuestReachability was restating IPv4, prefix, and MAC as strings; those already live in extdeps.network. A sweep of the other added scalars put evidence paths on FilePath, fixture digests on Sha256Digest, guest arch on Architecture, link speed on Bandwidth, and pids on Nat, instead of waiting for the next one-field review round. Co-authored-by: Cursor <cursoragent@cursor.com>
A record that carried empty: true beside procs_at_retirement: "empty", and a member list that restated placement_verdict.pid as prose, could disagree with nothing refusing. Derive the members from the verdict, drop the redundant retirement string, one CpuBoundStanding on the attempt, and inhabit IEEE duplex and Linux NUD instead of leaving those as untracked strings. Co-authored-by: Cursor <cursoragent@cursor.com>
The floor was FloorClean and the consumption witness passed; adjudication refused on namespace-wave-admission with exactly two unadjudicated deltas — cpu_bound_standing rebinding CpuBoundStanding and CpuBoundInterfacePresent onto the attempt module. Those rows dissolve when this PR merges. Co-authored-by: Cursor <cursoragent@cursor.com>
A receipt of observed constants cannot make that test red except by editing the receipt. Imports and folds are the consumption claim; the stall no longer cites the deleted witness as coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/v1/stage0/src/namespace_wave_admission.rs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Converting to draft rather than closing. This PR is a duplicate of #10818 at the identical commit Draft rather than close on purpose: closing an auto-opened PR whose branch still carries unmerged commits makes the dashboard open a successor, and that loop has already run three laps on another branch (#10629 → #10896 → #10900), discarding a REQUEST_CHANGES and a reviewer's dissent each lap. Draft removes merge-eligibility without triggering another lap. The CI failure reported against this PR is the same run as #10818's — one head, two vehicles. Track it on #10818. — sent from merry-bear-25 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baa03a7a99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TransitionAdmission { | ||
| label: "gunbc#10818 CpuBoundStanding rehome", |
There was a problem hiding this comment.
Because this commit's parent already contains #10692, the five earlier structural-text/logic rows bind to their admitted targets on both the base and head and therefore enter consumed_admissions. Adding the #10818 rows modifies ADMISSION_ROSTER_REL_PATH, so wave_admission_refusal sets consumed_due and the required namespace-admission lane refuses this revision even though the two new deltas are admitted. Delete the five consumed rows and their label as part of this roster edit.
Useful? React with 👍 / 👎.
|
Closing as not mergeable and superseded. Duplicate of #10818 at an older head. #10818 has merged, so CpuBoundStanding is on main. Measured against current main: this branch is 56 commits behind, and its content has landed by another route or should not land. Deleting the branch with the close so no successor PR is minted against it. — sent from merry-bear-25 |
Auto-opened by session-dashboard for session
royal-otter-33.Pushing to
session/royal-otter-33advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan