Skip to content

Resolver: fill record-lit owner when parent-enum lookup misses - #10852

Merged
briansrls merged 6 commits into
mainfrom
session/nimble-gull-102
Sep 8, 2026
Merged

briansrls merged 6 commits into
mainfrom
session/nimble-gull-102

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

Made with Cursor

gunbc-ci-auto-heal and others added 2 commits September 8, 2026 17:55
Co-authored-by: Cursor <cursoragent@cursor.com>

#10838 only filled lookup_type_by_name(parent) misses. When lookup_type_for on the locals Disj node fails under a larger resolve, parent-enum is Absent and Observed { } stayed a unit-arm Primitive — the belt_actuate:3532 specimen on bdec61e.
… file:line.

review 62580: the infer_record_lit owner comment transcribed a line number, SHA, and diagnostic string. Name the declaration and the larger-entry resolve that re-derives the miss instead.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

review 62580: agreed — the annotation used a file:line, a SHA, and a transcribed diagnostic string. It now names gunbc.roadmap_belt_actuate belt_sessions_observe_for_instance and the larger-entry resolve through tools.generated_artifact_gate (own --entry still typechecks; that dependency resolve is the producer that re-derives the miss). Logic unchanged.

— sent from nimble-gull-102

gunbc-ci-auto-heal and others added 3 commits September 8, 2026 18:42
required-witnesses-build refused stage0-mirrors on v1_compiler_infer.rs: the hand mirror was semantically the 04_infer.dag emit, not byte-identical.

Co-authored-by: Cursor <cursoragent@cursor.com>
…yields a unit arm.

The discriminating tree (one import of product.cable_plant_converge into fabric_switch_observed) still refused belt_sessions_observe_for_instance after the locals-on-parent-enum-miss fill: skip_owner_widen treated an on-chain unit-arm Observed as 'declares its own type', and a parent_enum spelling that is the arm itself never reached variant_owner_node or the declared-return coproduct.

Co-authored-by: Cursor <cursoragent@cursor.com>
…de once.

review 62614: carry the owner node from one variant_owner_node call; admit test.claim.record_lit_owner_route_witness on the required floor over the same subject bytes as own-entry vs a larger pool.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

review 62614:

  1. Discriminating consumer: test.claim.record_lit_owner_route_witness is admitted on required_gate_prefixes. It compiles the same subject bytes two ways via tools.multi_module_compile_fixture — own-entry vs a larger pool that adds an unimported extra module. Both arms expect compile-clean after the owner-fill; that is the enrolled positive control. It is the payload-Observed if-join geometry, not the isolated unit-arm analogue Resolver: widen record literals from the local coproduct owner node #10838 dropped. The intern-miss of tools.generated_artifact_gate over the live corpus is not a four-file manifest (that path is the required generated-artifact resolve already on CI).

  2. variant_owner_node is computed once as owner_from_variant_node and used for both local_variant_parent and the raw_resolved fallback.

review 62626: both compile_fixture arms were pinned compile-clean with no pre-fix RED on origin/main's resolver, so admitting them on required_gate_prefixes would cite a permanently-green pair as coverage. The intern-miss producer remains tools.generated_artifact_gate, not a four-file analogue.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

review 62626: agreed. Both compile_fixture arms were pinned compile-clean; nothing in the tree showed a pre-fix RED on origin/main's resolver, so admitting them on required_gate_prefixes would have been a permanently-green pair cited as coverage. Deleted the witness, the four fixture files, and the floor roster row. The intern-miss that gunbc.roadmap_belt_actuate belt_sessions_observe_for_instance hits under tools.generated_artifact_gate is still that required resolve (and the trigger tree), not a four-file analogue.

variant_owner_node remains bound once. This does not by itself close the production specimen.

@briansrls
briansrls merged commit 833286e into main Sep 8, 2026
4 checks passed
@briansrls
briansrls deleted the session/nimble-gull-102 branch September 8, 2026 20:38
gunbai-bot Bot pushed a commit that referenced this pull request Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant