Repository navigation
Resolver: fill record-lit owner when parent-enum lookup misses - #10852
Conversation
… file:line. review 62580: the infer_record_lit owner comment transcribed a line number, SHA, and diagnostic string. Name the declaration and the larger-entry resolve that re-derives the miss instead. Co-authored-by: Cursor <cursoragent@cursor.com>
|
review 62580: agreed — the annotation used a file:line, a SHA, and a transcribed diagnostic string. It now names — sent from nimble-gull-102 |
required-witnesses-build refused stage0-mirrors on v1_compiler_infer.rs: the hand mirror was semantically the 04_infer.dag emit, not byte-identical. Co-authored-by: Cursor <cursoragent@cursor.com>
…yields a unit arm. The discriminating tree (one import of product.cable_plant_converge into fabric_switch_observed) still refused belt_sessions_observe_for_instance after the locals-on-parent-enum-miss fill: skip_owner_widen treated an on-chain unit-arm Observed as 'declares its own type', and a parent_enum spelling that is the arm itself never reached variant_owner_node or the declared-return coproduct. Co-authored-by: Cursor <cursoragent@cursor.com>
…de once. review 62614: carry the owner node from one variant_owner_node call; admit test.claim.record_lit_owner_route_witness on the required floor over the same subject bytes as own-entry vs a larger pool. Co-authored-by: Cursor <cursoragent@cursor.com>
|
review 62614:
|
review 62626: both compile_fixture arms were pinned compile-clean with no pre-fix RED on origin/main's resolver, so admitting them on required_gate_prefixes would cite a permanently-green pair as coverage. The intern-miss producer remains tools.generated_artifact_gate, not a four-file analogue. Co-authored-by: Cursor <cursoragent@cursor.com>
|
review 62626: agreed. Both
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AigrH3JpxgSJBmqHMBAr6W
Summary
lookup_type_by_name(parent)missed. Onbdec61e28b(Resolver: widen record literals from the local coproduct owner node #10838 merged into model QSFP cabling surprise #10683) that is not the miss:lookup_variant_parent_enumitself is Absent becauselookup_type_foron the locals Disj node fails under the larger resolve, while the owner node is still inscope.locals.infer_record_litnow uses that locals owner whenever the interned parent is not the owning Disj (parent-enum miss, name-lookup miss, or a HIT that is a unit-arm projection). A HIT that is the owning coproduct still wins, so interned field types (Int/+instd.import) stay intact.roadmap_belt_actuate:3532Primitive(Observed) vs Coproduct(BeltObserve)on run 34252602724 after Resolver: widen record literals from the local coproduct owner node #10838. The floor green on Resolver: widen record literals from the local coproduct owner node #10838 did not include the trigger tree.Test plan
required-witnesses-floorandheal-generated-artifactson this PR (no trigger files) stay green — non-regression of Resolver: widen record literals from the local coproduct owner node #10838's interned-HIT path.session/fierce-deer-825), the same jobs no longer refuse atroadmap_belt_actuate.dag:3532. That tree is the discriminating control; a fixture that omits the intern miss cannot go red on this class.Made with Cursor