Repository navigation
Three callers still passed a parameter callees_from_node no longer takes - #10730
Merged
Merged
Conversation
callees_from_node declares (node, terminal_callee_symbols); the three call sites in fn_index_depth_agreement still passed param_names, so the required floor lane refused on every branch with a call shape mismatch. A signature change landed without its callers. The exclusion the argument fed is the one this module's own annotation already records as excluding nothing: no live declaration references its own parameter by a lexeme that also names a declaration. So the callers are corrected to the current two-parameter shape rather than the parameter being restored. param_names_of stays imported deliberately. It is still used independently by the collision measurement at line 118, so dropping the import to "clean up" after removing these three arguments would trade one break for another. Not verifiable by ordinary compilation: gunbc compile --source-root dag --source-root src/v2 does not reach this lens module -- it reports 37 blocking errors on main and none of them are these. Only claim_executor's floor lane observes the subject, so the floor is the oracle for this repair and a clean local compile establishes only that nothing else broke. The two end-of-file annotation failures in the same lane were already repaired by #10719 and are not part of this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XapoExtJQauXkqJCDS9dGs
This was referenced Sep 7, 2026
briansrls
pushed a commit
that referenced
this pull request
Sep 7, 2026
…kes (#10730) callees_from_node declares (node, terminal_callee_symbols); the three call sites in fn_index_depth_agreement still passed param_names, so the required floor lane refused on every branch with a call shape mismatch. A signature change landed without its callers. The exclusion the argument fed is the one this module's own annotation already records as excluding nothing: no live declaration references its own parameter by a lexeme that also names a declaration. So the callers are corrected to the current two-parameter shape rather than the parameter being restored. param_names_of stays imported deliberately. It is still used independently by the collision measurement at line 118, so dropping the import to "clean up" after removing these three arguments would trade one break for another. Not verifiable by ordinary compilation: gunbc compile --source-root dag --source-root src/v2 does not reach this lens module -- it reports 37 blocking errors on main and none of them are these. Only claim_executor's floor lane observes the subject, so the floor is the oracle for this repair and a clean local compile establishes only that nothing else broke. The two end-of-file annotation failures in the same lane were already repaired by #10719 and are not part of this change. Claude-Session: https://claude.ai/code/session_01XapoExtJQauXkqJCDS9dGs Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required floor lane refuses on every branch with a call shape mismatch:
callees_from_nodedeclares(node, terminal_callee_symbols), and the three call sites insrc/v2/lens/fn_index_depth_agreement.dagstill passparam_names. A signature change landed without its callers.The exclusion that argument fed is the one this module's own annotation already records as excluding nothing — no live declaration references its own parameter by a lexeme that also names a declaration — so the callers are corrected to the current two-parameter shape rather than the parameter being restored.
param_names_ofstays imported deliberately: the collision measurement at line 118 still uses it, so dropping the import after removing these three arguments would trade one break for another.On verification, stated honestly:
gunbc compile --source-root dag --source-root src/v2does not reach this lens module — it reports 37 blocking errors on main and none of them are these. Onlyclaim_executor's floor lane observes the subject, so the floor lane is the oracle here; a clean local compile establishes only that nothing else broke.The two end-of-file §4c annotation failures in the same lane were already repaired by #10719 and are not part of this change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XapoExtJQauXkqJCDS9dGs