Repository navigation
Affected-set as real v2 lens: consolidate test-selection authority on module-graph import-closure - #10642
Closed
gunbai-bot[bot] wants to merge 2 commits into
Closed
Affected-set as real v2 lens: consolidate test-selection authority on module-graph import-closure#10642gunbai-bot[bot] wants to merge 2 commits into
gunbai-bot[bot] wants to merge 2 commits into
Conversation
added 2 commits
September 6, 2026 03:20
… module-graph import-closure (§3)
Three mechanisms answered the question 'which tests are affected by this diff?':
1. v2.lens.affected_set (semantic Node-level lens) — stays as regen authority.
2. v2.lens.affected_set.corpus_dependency_view (fn-arrow Decl-level,
corpus_dependency_views_live) — DELETED. The fn-arrow DependencyView
primitives are removed outright; any dependent breaks loudly, which is
the section 3 census (delete-first: the deletion IS the census).
3. v2.lens.module_graph.entry_affected_by_touched_paths (import-closure) —
THE SURVIVOR. The Rust host mirror entry_file_touched_via_import_closure
is the certified host rendering.
Changes:
- entry_selection.dag: replaced fn-arrow DependencyView machinery with
delegation to module_graph.entry_affected_by_touched_paths_excluding.
Removed stale 'dead code' comment (the fn-arrow X is deleted, not deferred).
- corpus_dependency_view.dag: DELETED entirely (mechanism #2). No module
imported it after entry_selection.dag's delegation change, confirming
the census is clean.
- rust_stage0_gates.dag: updated comment referencing the deleted module.
- cli_run.rs: doc comments reflect consolidated §3 authority.
- Stale measurement receipt removed with deleted module. Measurement
instrument: claim_executor --source-root dag --source-root src/v2
--entry src/v2/lens/module_graph.dag --function entry_affected_by_touched_paths
with changed_paths as arg (timed externally).
Discriminating coverage: module_grain_affected_equivalence_tests certifies
the Dag-vs-Rust decision on real diffs with both positive and negative arms.
Instrument: claim_executor --source-root dag --source-root src/v2 --entry src/v2/test/claim/measure_fn_arrow_decl_facts_cost_test.dag --functions measure_decl_count Time this externally with 'time' or similar.
gunbai-bot
Bot
force-pushed
the
session/crisp-carp-360
branch
from
September 6, 2026 03:21
ac67ce2 to
cba8e65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the §3 fork where three mechanisms answered the question "which tests are affected by this diff?" by consolidating on module-graph import-closure (
v2.lens.module_graph.entry_affected_by_touched_paths) as the sole survivor.The three mechanisms
decl.output) — unwound from CI per fork (c) 2026-07-10 due to identity-vs-output-type conflation defect. Now delegates to . #3.What changed
entry_affected_by_touched_paths_excluding. The identity defect (decl.outputconflated with decl identity) is resolved because module-graph operates on import edges, not fn-arrow output nodes. Public API preserved (entry_affected_by_dependency_viewandentry_affected_by_dependency_view_excludingkeep the same signatures).fn_arrow_decl_facts_liveparse-only at ~11ms/file). Estimated current cost: ~15 seconds.Constraints followed
module_grain_affected_equivalence_testscertifies Dag-vs-Rust decision agreement on real diffs with both positive and negative armsDefinition of done
"gunbc test" selects tests from a real diff — the module-grain receipt harness proves this on two real merged diffs (dag-only and v2-only), asserting both affected and unaffected rows.