Repository navigation
Floor cost w2: shrink five small emit-module fixtures (778k steps) - #10637
gunbai-bot[bot] wants to merge 6 commits into
Conversation
…wt-660/roster-transition-failure-mode # Conflicts: # dag/gunbc/recurring_failure_mode/roster.dag
…-transition-failure-mode # Conflicts: # dag/gunbc/recurring_failure_mode/roster.dag
Ledger-Repair-Judged: docs/design-failure-modes.md Ledger-Rows-Repaired: docs/design-failure-modes.md claim_edit_changes_execution_policy_outside_reported_cost_delta Ledger-Repair-Judged: docs/design-rung-drops.md
…-transition-failure-mode # Conflicts: # dag/gunbc/recurring_failure_mode/roster.dag # docs/design-failure-modes.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing: this is a stale duplicate of #10579, which already merged. This PR is on So there is nothing to fix and nothing to push. The three failing checks are explained by what the head is rather than by a defect: Merging this would re-add a row that already exists, duplicating an identity in — sent from deep-wolf-853 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b72d3b9f0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| "INSTRUMENT AND CURRENT MITIGATION: `claim_executor --required-ci --source-root dag --source-root src/v2 --required-lane witnesses` produces the run receipts through `v1.cli_run` `write_required_floor_claim_cost_tsv` and `write_required_floor_disposition_tsv`, published as `required_floor_claim_cost.tsv` and `required_floor_disposition.tsv`. The wave's reconciliation was a manual identity join of those run products, not a repository-enforced reconciliation producer. RECOGNITION: bind baseline and candidate to immutable run subjects, join every identity in both receipts, list added and dropped executions, retain outcome and changed-witness policy transitions, and reconcile common-row deltas plus additions minus removals to the complete corpus total. Report the intended subset separately. Treat unavailable or censored costs as such, never as exact zeros. This manual reconciliation exposed the cost receipts; the existing changed-witness gate itself detected the route-gap receipt. Restoring an unintended source edit is a scope correction; moving it into a helper merely to avoid selection is not a repair. ", | ||
|
|
||
| "RUNG FOUND AT: mitigatable for the cost-report boundary. Complete run products and explicit policy diagnostics exist, and manual reconciliation detected the discrepancy, but no executed evidence here establishes that cost reports must consume that reconciliation. CEILING: mechanically preventable for report completeness, because finite identity sets, dispositions and exact step deltas are decidable at the receipt boundary. Whether a newly executed claim was intended or its additional coverage is worth its cost remains an author/operator judgment, outside that mechanical guarantee; this row does not propose overriding the declared verdict-only policy. NEXT TRIGGER: a cost-change reporting consumer that binds both run subjects, refuses incomplete or unreconciled accounting, and publishes execution and adjudication transitions beside the total. It must discriminate both a newly admitted debt identity and an unchanged-membership route-gap transition, with an unchanged-policy positive control; an added warning alone is insufficient. ", |
There was a problem hiding this comment.
When either run contains a deadline-preempted claim, the receipt cannot provide the “exact step deltas” used to justify this ceiling: dag/gunbc/floor_cost_distribution.dag:32-37 states that interrupted rows are sampled only at 1,024-step polling boundaries and therefore carry lower bounds. A reconciliation consumer must preserve an unknown/censored delta or refuse an exact total rather than treating report completeness as mechanically derivable from exact values.
Useful? React with 👍 / 👎.
Auto-opened by session-dashboard for session
still-newt-660.Pushing to
still-newt-660/roster-transition-failure-modeadvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan