Repository navigation
WORLD-CONVERGE: generalize fleet converge from HostIdentity to a global convergence subject, with the repo ruleset as one subject rather than a second authority - #10342
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing without a fix, because this PR is a re-opening of retired work and its failures are already repaired elsewhere. This is The work moved to #10324 on The two failing checks here are the floor reds I diagnosed on #10307 hours ago — undeclared witness fixture types, an optionality error at the The original author reviewed #10324 and confirmed the optionality repair preserved the three-state observation with an explicit Nothing is lost by closing this. Track #10324. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07bfa20bdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| subject: RepositoryRulesetConvergenceSubject, | ||
| _: Bool, | ||
| observed: RulesetObservation, | ||
| _: List<RulesetDivergence>, |
There was a problem hiding this comment.
Preserve detected ruleset divergences in verification failures
When any live ruleset field drifts, world_repo_ruleset_differences computes the precise RulesetDivergence values, but this parameter discards them and the current admission always returns RepositoryRulesetActuationUnbound. Consequently, verify() now reports only that no actuator is admitted instead of identifying the missing context, enforcement change, bypass grant, or other detected drift as the previous verifier did, leaving operators without the information needed to remediate the failed check. Carry or render these differences in the refusal path.
Useful? React with 👍 / 👎.
Auto-opened by session-dashboard for session
witty-otter-195.Pushing to
session/witty-otter-195advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan