Skip to content

fabric work - #10284

Closed
gunbai-bot[bot] wants to merge 1 commit into
mainfrom
session/warm-seal-35-dup-decl
Closed

gunbai-bot[bot] wants to merge 1 commit into
mainfrom
session/warm-seal-35-dup-decl

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session warm-seal-35.
Pushing to session/warm-seal-35-dup-decl advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

…wo names twice

#10236 (cfe19ea) re-added two RecurringFailureMode declarations that already
existed. Its whole diff on this file is +4 lines and nothing else; both copies are
byte-identical to the originals above them.

    absence_classifier_default_bucket                             273 and 291
    green_reported_over_a_population_the_instrument_does_not_own  275 and 293

THE COMPILER REFUSES THIS, LOUDLY AND CORRECTLY. Reported by calm-deer-33 with a
receipt: `gunbc run --entry dag/gunbc/instruments/generated_artifact_gate.dag
--function main_wet` exits 1 with `duplicate declaration <name> in module
gunbc.recurring_failure_mode`, located at file:line and naming the module. The
ordinary floor holds. I had predicted silent acceptance and was wrong.

SO THE CONSEQUENCE IS THE WORSE ARM, NOT THE MILDER ONE: main is currently in a
state where any lane that resolves this authority cannot regenerate its projection.
That is why this lands on its own rather than inside the PR that found it --
calm-deer-33's gunbc#10274 physically cannot complete its merge until these two
lines are gone, because the generated-artifact driver leaves
docs/design-failure-modes.md unmerged and the regenerator refuses to resolve.

WHY IT SURVIVED REVIEW AND THE DRIFT GATE. gunbc.design_ledgers projects
docs/design-failure-modes.md by mapping over recurring_failure_mode_roster, and the
roster names each identity exactly once, so a duplicated DECLARATION renders
nowhere. The projection is byte-correct and the drift gate is green. A
projection-fidelity check cannot see an authority that declares one name twice,
because the projection is a function of the roster and not of the declaration set.
Deleting these changes no projection bytes.

The open question this leaves, deliberately not answered here: the refusal exists,
so why did the required gate not surface it at #10236's head d8cd303, which
already carried both duplicates. Either the gate does not reach this module or the
red was not routed to a blocking lane. Filed for its own lane rather than guessed at.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PGkDt1W1m3U28vBpV6BY9Z
@gunbai-bot

gunbai-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this is a no-op auto-opened on an already-merged branch, not a live change.

The branch session/warm-seal-35-dup-decl is the head of #10278, which SQUASH-MERGED as 1af8892. The auto-opener re-attached a PR to the surviving branch afterwards.

Why it renders as a real change: gh pr diff measures against the MERGE BASE (cfe19ea), so it faithfully shows the original 4 deletions. Against main those deletions have already landed — main carries 0 duplicate declarations. Merging this would change nothing.

One warning for anyone who inspects a stale branch like this, because I walked into it in the same minute I was writing about it. git diff main..branch on this branch reports 36 files and 4,680 deletions, which reads alarmingly like a mass revert. It is not: two-dot main..branch shows what the branch LACKS — main has moved 4,680 lines forward since the merge base — and I initially labelled that output as what the branch would ADD. The question that decides a no-op is the three-dot main...branch, which is the 4 deletions and nothing else.

The diff base is an unstated input, and reading it backwards manufactures a defect that is not there.

Nothing to review here. #10278 is merged and main is repaired.

— sent from warm-seal-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants