Skip to content

BT-0: gunbc build gunbc — commanded exact build through the emitted CLI - #10220

Closed
briansrls wants to merge 35 commits into
mainfrom
session/quick-heron-173
Closed

briansrls wants to merge 35 commits into
mainfrom
session/quick-heron-173

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session quick-heron-173.
Pushing to session/quick-heron-173 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 30 commits August 30, 2026 20:38
# Conflicts:
#	dag/gunbc/seed_growth_admission.dag
#	src/v1/stage0/src/main.rs
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
# Conflicts:
#	src/v1/stage0/src/emitted_population.rs
#	src/v1/stage0/src/lib.rs
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
# Conflicts:
#	src/v1/stage0/src/emitted_population.rs
#	src/v1/stage0/src/extdeps_languages_rust_emit.rs
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
…across three seed generations

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q7kxQnLVogzdgyRYTfpjEn
# Conflicts:
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
#	src/v2/workflow/floor_expected_red.dag
# Conflicts:
#	src/v1/stage0/src/emitted_population.rs
#	src/v1/stage0/src/lib.rs
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
# Conflicts:
#	src/v1/stage0/src/emitted_population.rs
#	src/v1/stage0/src/gunbc_cli_dispatch_surface.rs
#	src/v1/stage0/src/main.rs
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
# Conflicts:
#	src/v1/stage0/src/lib.rs
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
# Conflicts:
#	src/v1/stage0/src/v1_compiler_emit_rust.rs
@briansrls
briansrls marked this pull request as ready for review September 3, 2026 10:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T11:06:03.012789Z 99d4c37 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99d4c37edb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

public_operands: [
CliBootstrapOperandBinding { parameter: "program", operand_field: "program" },
],
receipt: CliBootstrapReceiptChannel { parameter: "receipt_path", path: ".gunbc-build-receipts" },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep build receipts out of the source snapshot

After any configured gunbc build invocation, this directory retains both the receipt and the built executable at <receipt>.artifact; it is not covered by the repository's /.gunbc/ ignore rule, and the launcher never removes it. On the next invocation, devboot_snapshot stages all non-ignored untracked files with add -A, so the previous executable changes the source tree and cache token, preventing warm reuse and accumulating another large binary in every subsequent snapshot. Put this channel under the ignored .gunbc/ workspace or remove its files before snapshotting.

Useful? React with 👍 / 👎.

@gunbai-bot

gunbai-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Closing again as the same duplicate — this is #10153 re-opened under a new number, and closing alone will not stop it recurring.

Same head, same branch: 99d4c37edb3 on session/quick-heron-173, the surviving feature branch from #9775, which was squash-merged. Squash does not make the old head an ancestor of main, so the branch keeps looking unmerged and the dashboard re-opens it on activity. I closed it as #10153 at ~10:2xZ; it returned as #10220 at 10:59Z.

The diff is already in main (re-verified): 01b6a78a3e55 is an ancestor of main; build_identity.dag, the source_roots field, regen_convergence_transaction_witness_test.dag, and the CliDispatchGuaranteePosition/CliDispatchRungClass declarations flagged in review 59265 are all present on origin/main today. There is nothing here to merge.

On review 59265 — the findings are real, and they are about main, not about this PR. I verified the load-bearing one rather than dismissing it with the PR:

gunbc.guarantee_rung_drop already owns GuaranteeRung = OutsideTheLadder | Mitigatable | MechanicallyPreventable | StructurallyGuaranteed | StructurallyImpossible. The CliDispatch-prefixed pair mints CliDispatchGuaranteePosition = CliDispatchStructurallyGuaranteed | CliDispatchOutsideGuaranteeLadder plus a CliDispatchRungClass carrying identity / invalid_state / harm / found_at / ceiling — which is the §4b row shape the existing authority already carries. So it is a §3 fork, and notably OutsideTheLadder already exists, so the reviewer's suggested escape hatch ("extend it if an outside-ladder variant is genuinely needed") is unnecessary: the fork was minted for a capability the authority already had.

That is a genuine consolidation owed on dag/gunbc/cli_dispatch_surface.dag, which is the BT lane's file. It will be carried by the BT-2 re-emission transaction rather than by resurrecting a landed PR — BT-2 already has to rewrite that carrier and regenerate both of its seed mirrors, so folding the consolidation in costs one re-emission instead of two.

The main.rs trailing std::process::exit(0) after a -> ! dispatch is noted as dead code and will ride the same change.

To stop the recurrence: the branch needs to stop carrying a landed diff — resetting session/quick-heron-173 to origin/main makes the auto-opened PR empty. Not deleting the branch here, since it is another session's working branch.

— sent from tidy-lynx-804

@gunbai-bot gunbai-bot Bot closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant