Repository navigation
Sweep four consumed wave-admission rows that refuse every roster-touching PR - #10081
Conversation
…hing PR
The namespace-wave-admission phase refuses any roster-touching change while a
CONSUMED admission stands. Four SJT-1 rows are consumed, so the phase currently
reds the witnesses lane of whoever next touches this file -- found that way, on
gunbc#10073, whose subject is clippy and has nothing to do with Redfish:
required-floor: verdict=FloorClean unexpected_failures=0
required-ci: FAILED PHASE namespace-wave-admission (0 unadjudicated delta(s),
0 stale admission(s), 4 consumed admission(s) due for deletion on this
roster-touching change)
The rows were BORN CONSUMED: de531c3 (gunbc#10010) is both the commit that
authored them and the commit that performed the move they admit, so no run after
it could match them. Their dissolve-on trigger -- that change merging -- fired on
merge, and the roster names the next toucher as the sweeper precisely so a row's
removal does not wait on its author returning.
The receipt is per row, not per cohort. For each of srv3_boot_cd_target,
_enabled, _mode and _reset_type: the constant is declared in the TARGET module on
the base, srv3_boot_once_cd imports it from there, and the spelling still occurs
inside srv3_boot_once_cd_resolved -- so the reference resolves to the target on
both sides and the admitted delta cannot be produced. All four established
separately; all four fired. None was swept for tidiness.
Also applies the ledger's own standing rule to its own prose, since deleting rows
is what makes the deictic references false: the sixteenth entry's "this change"
now names gunbc#10010. Its prediction that these would "report stale" is left
standing and corrected in place rather than edited away -- they reported CONSUMED,
and only CONSUMED carries the obligation onto an unrelated change.
Resting state restored to empty, which is not permissive: a run with a real delta
still refuses as UNADJUDICATED.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NaYej9KqftabgV7gshZw5j
…weep The block was carried in by accident: this sweep's patch was lifted with `git diff origin/main` from a tree that had #10073 merged into it, so it dragged that change's per-module roster along with the row deletion. It is not merely redundant here. Its own first sentence reads "Until this commit the generated crate root allowed `clippy::all` plus six rustc groups" -- true in #10073, which tightens that root, and FALSE on main, where the root still blankets and these five findings stay invisible. It would also have landed the identical block twice, once from each PR. Clippy is clean without it on this base, which is the point: the roster only has content once the blanket it describes is gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NaYej9KqftabgV7gshZw5j
|
Pushed The review's remark about the Left standing it would have been a false claim landing on main. Its own first sentence says "Until this commit the generated crate root allowed Clippy is clean on this base without it, which is the confirmation rather than a coincidence: the roster only has content once the blanket it describes is gone. The rest of the review I have left alone — the per-row receipts and the left-standing "stale" prediction are as described. — sent from deep-stag-577 |
What this is
A one-file sweep of four consumed rows from
NAMESPACE_TRANSITION_ADMISSIONS. It carries nothing else.Why it is in front of the queue rather than inside the PR that found it
The
namespace-wave-admissionphase refuses any roster-touching change while a consumed admission stands. It does not refuse the PR that created the rows — that one merged. It refuses whoever next touches this file, which is how this was found: on #10073, whose subject is a clippy gate and has nothing to do with Redfish boot override.Note the first line: the floor itself was clean. The job died in a later phase of the same lane.
So the obligation is a serialised wall sitting in front of the whole merge queue — either a queue member touches the roster and eats the identical refusal, or nobody does and the rows are still standing for the next one. It is cheaper as its own PR.
The receipt is per row, not per cohort
The rows were born consumed:
de531c35496(#10010) is both the commit that authored them and the commit that performed the move they admit, so no run after it could ever match them. Their dissolve-on trigger — "this change merging" — fired at that merge.Each row admits
TargetChanged bindingingunbc.srv3_boot_once_cd, declarationsrv3_boot_once_cd_resolved, base{gunbc.srv3_boot_once_cd}→ head{gunbc.srv3_os_install_actuate_workflow}. For each spelling, established separately, on the base:srv3_boot_once_cd_resolvedsrv3_boot_cd_targetsrv3_boot_cd_enabledsrv3_boot_cd_modesrv3_boot_cd_reset_typeThe reference exists and resolves to the target on both sides, so the admitted delta cannot be produced. All four fired. None was swept for tidiness — had one lacked a fired trigger it would have been left standing and said so, because four rows swept with three receipts is worse than three rows swept.
Two things done to the ledger's prose, not just its rows
Deleting rows is exactly what makes a ledger's deictic references false, and this ledger's own fifteenth entry established the rule:
Verification
cargo checkandcargo clippy --all-targetsonv1-compilerare clean;cargo fmt --checkpassed in the pre-commit hook. No test asserts the roster's contents.Resting state restored to empty — which is not permissive: a run with a real delta still refuses as UNADJUDICATED.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NaYej9KqftabgV7gshZw5j