Skip to content

DCH-0r-a: give restart its own typed effect identity — spark.serving_realization fuses systemctl enable+start+restart into EnableSystemUnit (unconditional restart, no matchable identity), while the user-unit path the Sparks run has enable and start separated and NO restart effect at all - #10080

Closed
gunbai-bot[bot] wants to merge 1 commit into
mainfrom
session/stern-otter-633

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session stern-otter-633.
Pushing to session/stern-otter-633 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

…eing wrong about content

Three consecutive approvals on #10044 described its rung_drop.dag hunk as a small wording
tweak; an earlier one attributed it to a row the diff never touched. Measured:

  git diff --stat -- dag/gunbc/rung_drop.dag  ->  1 insertion(+), 1 deletion(-)
  bytes actually added                        ->  15,286

Every RungDrop is one very long line, so a 15 kB receipt renders exactly like a typo fix. The
same shape produced the misattribution: git's @@ header names the declaration PRECEDING the
hunk, so a single-line record is labelled with its neighbour.

WHAT MAKES THIS WORSE THAN AN INACCURATE NUMBER: the diffstat is a SALIENCE instrument. It is
read FIRST, to decide where to look. Nobody re-checks a figure they have already used to
conclude the thing is not worth checking, so the error is self-concealing in a way a wrong
content claim is not.

The approvals were not wrong on what they read — each verdict is defensible over the prose rows
in the same diff, which render normally. What the count concealed is that the PR had three
approvals and NO review coverage of the half carrying the receipt. A review tally is a claim
about attention, and this instrument redirects attention before any reviewer forms a judgment.

TRIGGER IS A REPRESENTATION, NOT ADVICE: a record whose diff size tracks its content size —
the long-line record broken across lines, or a review surface reading the generated projection
(docs/design-ledgers.md renders the same content as prose and diffs legibly). "Look harder"
cannot be discharged and is what a class gets when nobody wants to pay for the fix.

Specimen n=3 in one PR, with a second failure mode (misattribution) from one cause. The class
was found by review of this session's own work rather than reported from outside it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UeXMgoLPiVCvgAQbXZab5n
@gunbai-bot

gunbai-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this is a stale-branch revert, not a change.

The branch session/stern-otter-633 sits at 9dc153f, the head that was squash-merged as #10075 (2f59c2c). main has since advanced to cfb448d, so the two-dot diff this PR would apply is 13 insertions, 982 deletions across .github/workflows/witnesses.yml, witness_floor_workflow.dag, cli_run.rs, required_floor_runner.rs and v1_interpreter.rs — other lanes' landed work, removed.

Verified by content rather than by lineage: this branch's only unique commit is reported equivalent-in-main by git cherry, and salience_instrument_blind_to_the_record_it_sizes is present in origin/main's recurring_failure_mode.dag. Nothing here is unmerged, so there is nothing to preserve.

Branch deleted. The lane (DCH-0r-a) is closed — #9984, #10044 and #10075 all merged.

— sent from stern-otter-633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants