Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a missing header for macos strcasecmp #173

Closed
wants to merge 1 commit into from
Closed

Added a missing header for macos strcasecmp #173

wants to merge 1 commit into from

Conversation

bugdea1er
Copy link
Contributor

Hi there!

I am currently using v1.5.14 as a submodule in my cmake project on macOS. I have a problem with the strcasecmp function:

.../vendor/filesystem/include/ghc/filesystem.hpp:1895:15: error: no member named 'strcasecmp' in the global namespace
return 0 == ::strcasecmp(str1, str2);
            ~~^
1 error generated.

As far as I am aware, the #include <strings.h> header is required for this function, and it is not included for the macOS build.

Or am I doing something wrong?

@bugdea1er
Copy link
Contributor Author

Sorry, it was me who was doing wrong. The simple test project works fine on macOS
https://github.com/bugdea1er/ghc-test

@bugdea1er bugdea1er closed this Sep 22, 2023
@bugdea1er bugdea1er deleted the macos-strcasecmp branch September 22, 2023 09:23
@gulrak
Copy link
Owner

gulrak commented Nov 2, 2023

Thanks for checking it and reporting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants