Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC_NO_DIRENT_D_TYPE should be defined on Solaris #142

Closed
lhruska opened this issue Apr 1, 2022 · 6 comments
Closed

GHC_NO_DIRENT_D_TYPE should be defined on Solaris #142

lhruska opened this issue Apr 1, 2022 · 6 comments
Assignees
Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request
Milestone

Comments

@lhruska
Copy link

lhruska commented Apr 1, 2022

Describe the bug
Filesystem fails to compile (filesystem/filesystem.hpp) on Solaris because of missing d_type in dirent structure.

Additional context
Doxygen issue

@gulrak gulrak self-assigned this Apr 1, 2022
@gulrak gulrak added the enhancement New feature or request label Apr 1, 2022
@gulrak
Copy link
Owner

gulrak commented Apr 1, 2022

I'll look into it.

@albert-github
Copy link
Contributor

The reference: doxygen/doxygen@933c0ec is better as here also the GHC_OS_SOLARIS is set

gulrak added a commit that referenced this issue Apr 2, 2022
gulrak added a commit that referenced this issue Apr 2, 2022
gulrak added a commit that referenced this issue Apr 2, 2022
gulrak added a commit that referenced this issue Apr 2, 2022
gulrak added a commit that referenced this issue Apr 2, 2022
Took 2 minutes
@gulrak
Copy link
Owner

gulrak commented Apr 2, 2022

I'll decided against another GHC_NO_DIRENT_D_TYPE and instead removed it and implemented compile time detection of the dirent variant. Got the whole test suite to successfully run on a Solaris 10 and hopefully will make a release until tomorrow.
Just need to figure out the GitHub workflow issue with VS2019.

@gulrak gulrak added this to the 1.5.12 milestone Apr 2, 2022
gulrak added a commit that referenced this issue Apr 2, 2022
@phprus
Copy link
Contributor

phprus commented Apr 2, 2022

@gulrak
CentOS 8 build is failed.
Solution: migrate from CentOS 8 to CentOS 8 Stream (like this e8a17c1)

gulrak added a commit that referenced this issue Apr 2, 2022
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Apr 2, 2022
@gulrak
Copy link
Owner

gulrak commented Apr 3, 2022

Released with v1.5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants