Merge pull request #34 from jeanguyomarch/toctou-race

fix: TOCTOU race when creating directories
gulrak · Nov 6, 2019 · 741eaca · 741eaca
2 parents 9db85fa + b5df8c5
commit 741eaca
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/include/ghc/filesystem.hpp b/include/ghc/filesystem.hpp
@@ -3391,7 +3391,12 @@ GHC_INLINE bool create_directories(const path& p, std::error_code& ec) noexcept
             if (!exists(fs)) {
                 create_directory(current, ec);
                 if (ec) {
-                    return false;
+                    std::error_code tmp_ec;
+                    if (is_directory(current, tmp_ec)) {
+                        ec.clear();
+                    } else {
+                        return false;
+                    }
                 }
             }
 #ifndef LWG_2935_BEHAVIOUR