Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for updateMetadata to pass fd to callback #174

Merged
merged 1 commit into from
Jun 28, 2016
Merged

No need for updateMetadata to pass fd to callback #174

merged 1 commit into from
Jun 28, 2016

Conversation

erikkemperman
Copy link
Member

As discussed here.

@erikkemperman
Copy link
Member Author

Ugh, Travis failed. Same commit passed on my repo earlier.

Expected 1465286297000 to be greater than 1465286297000

Very round timestamps, maybe still some edge case in the futimes tests? I'll look into this if I find some time.

@erikkemperman
Copy link
Member Author

Submitted a separate PR to address the failing test. But I think this futimes failure is rare, and definitely unrelated to this particular patch. Restarting the travis build ought to be sufficient.

@phated phated merged commit 0b5e797 into gulpjs:master Jun 28, 2016
@erikkemperman erikkemperman deleted the refactor-updatemeta-cb branch June 29, 2016 07:51
@erikkemperman erikkemperman restored the refactor-updatemeta-cb branch June 29, 2016 07:51
@erikkemperman erikkemperman deleted the refactor-updatemeta-cb branch June 29, 2016 07:59
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
6d8be3c
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
8a6ffd0
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
185689b
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
732004e
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
669237e
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
7e3c11e
phated pushed a commit that referenced this pull request Nov 27, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
bcff979
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
6118b12
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
76ddd01
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
1a29f2e
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
c819d93
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
48d4e3f
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
efde747
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
4859a67
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
25a8561
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
0bba0b5
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
86e0eb4
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
366c357
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
9b35736
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
591514e
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
6788bc1
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
423c935
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
07a84cb
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
e036c14
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
ac8b64d
phated pushed a commit that referenced this pull request Nov 28, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
f682573
phated pushed a commit that referenced this pull request Nov 30, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
4fe38d6
phated pushed a commit that referenced this pull request Nov 30, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
07c47e0
phated pushed a commit that referenced this pull request Nov 30, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
043ffbd
phated pushed a commit that referenced this pull request Nov 30, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
dd3cbcf
phated pushed a commit that referenced this pull request Nov 30, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
a273d3c
phated pushed a commit that referenced this pull request Dec 5, 2017
@erikkemperman @phated
Update: Avoid passing fd to updateMetadata callback (#174)
f73c065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikkemperman @phated