Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing uid/gid from the vinyl object to the file on disk #157

Closed
phated opened this issue Feb 26, 2016 · 4 comments
Closed

Support changing uid/gid from the vinyl object to the file on disk #157

phated opened this issue Feb 26, 2016 · 4 comments
Milestone

Comments

@phated
Copy link
Member

phated commented Feb 26, 2016

We now allow mtime, atime and mode to be set on the actual file if they exist on the vinyl object. We should also support uid and gid through use of fs.fchown.

Ref #151 (comment)

@phated phated modified the milestone: 3.0.0 Mar 1, 2016
@phated
Copy link
Member Author

phated commented Mar 28, 2016

@erikkemperman @piranna would either of you have time to look into this?

@erikkemperman
Copy link
Member

Probably not much, swamped at work.

For what it's worth, I expect this to be pretty easy to implement but annoying to test (cough-windows-cough).

@erikkemperman
Copy link
Member

Sweet!

@ghost
Copy link

ghost commented Jun 22, 2017

@phated closed this in 9fd1689 on Jul 6, 2016

Looks like this was fixed. However, I still see a chown fail

sindresorhus/gulp-chown#5 (comment)

using gulp-chown. That was originally pointed at vinyl-fs as the culprit, but I've installed vinyl-fs#master, and still see the problem. Just checking in to see which thread to pull on -- gulp-chown, gulp-dest, or still vinyl-fs .., ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants