Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping findup-sync #54

Closed
tkellen opened this issue Sep 15, 2015 · 3 comments
Closed

bumping findup-sync #54

tkellen opened this issue Sep 15, 2015 · 3 comments

Comments

@tkellen
Copy link

tkellen commented Sep 15, 2015

Whatcha think, @phated? Minor or major bump here for Liftoff?

@tkellen
Copy link
Author

tkellen commented Sep 15, 2015

@phated
Copy link
Member

phated commented Sep 15, 2015

@tkellen we control all the lookups using findup-sync, correct? No user input for globs? And I am pretty sure none of our usage was reliant on globs breaking changes so we should be able to get away with a minor (unless I am mistaken on the 2 questions I asked).

@tkellen
Copy link
Author

tkellen commented Sep 18, 2015

You're right, we can totally do this as a minor bump.

@phated phated closed this as completed in 86c48b6 Sep 21, 2015
tkellen pushed a commit that referenced this issue Jul 25, 2016
phated added a commit that referenced this issue Nov 21, 2021
phated added a commit that referenced this issue Nov 21, 2021
phated added a commit that referenced this issue Nov 22, 2021
phated added a commit that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants