-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update and refactor release workflow recipe #2498
Conversation
The only piece of functionality that I didn't try to test is |
0bcb5f8
to
8222ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is looking really good, but I had a few questions/comments.
Also, once you finish up a recipe, please add the Frontmatter like the other docs so it will be pulled in when I publish the website. Thanks!
- infer version bump from commits - make release commit message adhere to Conventional Commits - read GitHub personal access token from git-ignored `.env` file - functions instead of `gulp.task` - eliminate usage of gulp plugins - improve readability with `execa` and `util.promisify`
8222ed9
to
d2315c5
Compare
I forgot to ask, what frontmatter are you referring to? 🤔 |
Oh, I see the frontmatter now, I'll add it as soon as I figure out which values to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made an inline suggestion for the frontmatter, and I also shrunk the name of the recipe.
Co-authored-by: Blaine Bublitz <[email protected]>
Got it! Is that it, then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! This looks great! Thank you 😄
Looks awesome! https://gulpjs.com/docs/en/recipes/automate-releases Thanks again! |
🔥 🔥 🔥
.env
filegulp.task
execa
andpify
I like this recipe because it can be used as inspiration even by those who want to build something completely different.
Ref. #2164.