Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template rendering fails when using an undefined variable #26

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Template rendering fails when using an undefined variable #26

merged 1 commit into from
Apr 23, 2018

Conversation

j-vizcaino
Copy link
Contributor

@j-vizcaino j-vizcaino commented Apr 23, 2018

Summary

Rendering fails when using an undefined variable.
Previous implementation was replacing the value with <no value>.
For more information, see https://devdocs.io/go/text/template/index#Template.Option

Closing issues

Fixes #25

Checklist

  • Have you fmt your code locally prior to submission (orbit run fmt)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (orbit run ci)?
  • I have squashed any insignificant commits

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@28db184). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #26   +/-   ##
=========================================
  Coverage          ?   93.11%           
=========================================
  Files             ?        7           
  Lines             ?      218           
  Branches          ?        0           
=========================================
  Hits              ?      203           
  Misses            ?        7           
  Partials          ?        8
Impacted Files Coverage Δ
app/generator/generator.go 89.74% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28db184...0a8fdb4. Read the comment docs.

@gulien gulien merged commit 1997756 into gulien:master Apr 23, 2018
@j-vizcaino j-vizcaino deleted the template-error-on-missing-value branch April 24, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants