Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request MetaMask network change if the user if on a wrong one #79

Merged
merged 10 commits into from
Aug 3, 2021

Conversation

cs-balazs
Copy link
Collaborator

Closes #1

For now on the all communities page, I just hardcoded to request the change to polygon, but I think we should design, and implement a more complex dialog system to let the user know what the chains we support (maybe how many communities are available on them), so the user can choose one.
For this, I think we would have to refactor the community provider, and have an "availableChains" or something like that, which contains the original chainData, not just the "current one". Also, the current chainData key should be undefined if the community is not available on the chosen chain?

I don't really get why we want to show all the communities in the explorer, not just the ones available on the chosen chain, I think we should at least indicate that the community is not available

@cs-balazs cs-balazs added enhancement New feature or request agora-frontend Related to the agora-frontend repository. labels Aug 2, 2021
@cs-balazs cs-balazs requested a review from dovalid August 2, 2021 08:12
@cs-balazs cs-balazs self-assigned this Aug 2, 2021
@vercel
Copy link

vercel bot commented Aug 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zgen/agora-frontend/hQnku3ERR9e4wn7Siq5zqpkMSvob
✅ Preview: https://agora-frontend-git-i1-metamask-network-change-zgen.vercel.app

also adjusted local community data
@dovalid dovalid merged commit d6b86b4 into main Aug 3, 2021
@dovalid dovalid deleted the I1-metamask-network-change branch August 3, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agora-frontend Related to the agora-frontend repository. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request network change via MetaMask if the user is on the wrong network
2 participants