-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image caption #194
Comments
Hi! No its not possible at this time i'm afraid. I don't know the docx spec well enough to judge whether this would be difficult to add... This is the function that is concerned with injecting image-related nodes into the document XML. docx-templates/src/processTemplate.ts Lines 759 to 854 in f3e33ff
Happy to take a look at a PR. |
Should be possible to add this feature in a way similar to how image rotation was added in #221 . See http://officeopenxml.com/drwPic-nvPicPr.php |
Hi @jjhbw, have we had this feature in the latest version of docx-template? |
@PhuocHoangMinhNguyen i'm afraid not. I didn't get around to it yet. Rotation can be handled from JS though, outside of docx-templates. |
@jjhbw It's okay man. Just wondering what do you mean by "didn't get around to it yet"? Is it hard or you haven't had time to look into it? If it is the latter, I will try to look in the code then, we are in dire need of this feature. |
Would be great if you could take a look. I'm swamped with other work at the moment, but happy to look at your PR. |
I also needed this functionality so I've created a PR for this: #286 |
Thanks @jwasnoggin ! Looks like a sensible solution to me. |
Hi @jjhbw |
@as19ish The GH Action that we use to publish on NPM broke due to a new 2FA requirement. I'm working with @guigrpa to get that resolved. If you'd rather not wait you can install the commit directly from github in the meantime, see https://stackoverflow.com/a/18049685 |
Hi,
Is it possible to add image caption? couldn't see any information about it in docs. If not could you point me where +/- it should be added I can try to add pull request.
The text was updated successfully, but these errors were encountered: