Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update devcontainer configuration to work with DevPod and forward environment from host. #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesdobson
Copy link
Contributor

I tried this code with DevPod + Atmos, and I also tried it with Rancher Desktop.

The chmod of /var/run was needed for accessing the docker socket in the DevPod + Atmos configuration.

The environment variable forwarding prevents us from accidentally checking in credentials in devcontainer.json; instead, we just define these variables on our host session or profile.

…ard environment from host

Signed-off-by: James Dobson <[email protected]>
Copy link

@jaswalkiranavtar jaswalkiranavtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants