Provider artifactory user and group #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Wong <[email protected]>
Signed-off-by: Jeffrey Wong <[email protected]>
… as it is deprecated Signed-off-by: Jeffrey Wong <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
jaswalkiranavtar
requested review from
jaswalkiranavtar,
jamesdobson,
ramekris3163,
suvaanshkumar,
jeffw17 and
amrcoder
| Name: &userName, | ||
| Email: ptr.To(email), | ||
| }, | ||
| ResourceSpec: v1.ResourceSpec{ |
There was a problem hiding this comment.
We should also add a password here
|
we should also add examples for User and Group resources |
jaswalkiranavtar
requested changes
Mar 12, 2025
amrcoder
reviewed
Mar 12, 2025
| Expect(retrievedUser.Email).To(Equal(email)) | ||
| }) | ||
|
|
||
| AfterEach(func(ctx SpecContext) { |
There was a problem hiding this comment.
Do we also clean up the group resource created in these tests somewhere?
There was a problem hiding this comment.
Yes it is cleaned up in the DeferCleanup block which runs in every test case.
amrcoder
reviewed
Mar 12, 2025
e2e/e2e_suite_test.go
Outdated
| Expect(err).NotTo(HaveOccurred()) | ||
| // err = v1alpha1permission.AddToScheme(scheme) |
There was a problem hiding this comment.
Can this be removed from here?
added examples. |
jeffw17
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Generate provider resources and tests for artifactory user and group
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested