Skip to content

Add AcceptsPositionalArgs regression tests for all non-positional clets#75

Merged
tig merged 2 commits into
developfrom
copilot/fix-clets-reject-positional-args
May 6, 2026
Merged

Add AcceptsPositionalArgs regression tests for all non-positional clets#75
tig merged 2 commits into
developfrom
copilot/fix-clets-reject-positional-args

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

The AcceptsPositionalArgs property and validation logic (D-025, PR #55) already landed on develop. However, only IntCletTests had an explicit AcceptsPositionalArgs_IsFalse regression test among non-positional clets.

This PR adds the missing regression tests for all 12 remaining non-positional clets:

  • ColorCletTests
  • ConfirmCletTests
  • DateCletTests
  • DecimalCletTests
  • DurationCletTests
  • TimeCletTests
  • RangeCletTests
  • AttributePickerCletTests
  • TextCletTests
  • MultilineTextCletTests
  • PickFileCletTests
  • PickDirectoryCletTests

Each test follows the established pattern:

[Fact]
public void AcceptsPositionalArgs_IsFalse ()
{
    IClet clet = new ColorClet ();

    Assert.False (clet.AcceptsPositionalArgs);
}

Tests via the IClet interface to exercise the default interface member. Catches accidental => true overrides on clets that should reject positional args.

Copilot AI assigned Copilot and tig May 6, 2026
Copilot AI linked an issue May 6, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix clets that don't accept positional args to reject them Add AcceptsPositionalArgs regression tests for all non-positional clets May 6, 2026
Copilot finished work on behalf of tig May 6, 2026 15:27
Copilot AI requested a review from tig May 6, 2026 15:27
@tig tig marked this pull request as ready for review May 6, 2026 15:47
@tig tig merged commit 8cd942b into develop May 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clets that don't accept positional args should reject them

2 participants