Fixes #5459. Integrated sixel raster output, improved `ImageView` and scenarios by tig · Pull Request #5460 · gui-cs/Terminal.Gui

tig · 2026-06-01T04:07:27Z

Summary

Integrate sixel raster output into IOutputBuffer/OutputBase, including clipping-aware composition and pre-encoded sixel reuse for full visible raster images.
Route ImageView sixel drawing through the output buffer and fix first-render/card sizing issues across sixel and cell-based rendering.
Add focused ImageView keyboard handling: arrow/scroll keys are consumed, panning works when zoomed, PageUp zooms in, PageDown zooms out, and zoom-out can shrink to a 1x1 rendered image.
Add optional background rendering for ImageView; async rendering scales and sixel-encodes off the UI thread, keeps the last completed frame visible, and shows an Aesthetic2 SpinnerView while work is pending.
Enable async rendering by default in the UICatalog Images scenario with a checkbox toggle, and refine related image palette/scenario code.
Split ImageView into focused partials under Terminal.Gui/Views/ImageView/ and colocate backing fields with their properties or first use.
Ignore generated *.actual snapshot artifacts and remove the accidentally committed snapshot output.

Tests

dotnet build Terminal.Gui --artifacts-path ...\isolated-build-artifacts
dotnet build Examples\UICatalog --artifacts-path ...\isolated-build-artifacts
dotnet test --project Tests\UnitTestsParallelizable --filter-class "*ImageViewTests" --artifacts-path ...\isolated-test-artifacts
dotnet test --project Tests\UnitTestsParallelizable --filter-class "*OutputBaseTests" --artifacts-path ...\isolated-test-artifacts
GitHub Actions CI/CD is running on the latest pushed commit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd87e87ccd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Integrates sixel raster output into the normal output-buffer composition path (with clip capture), routes ImageView sixel rendering through this buffer, and adds a UICatalog scenario to exercise clipping/overlay behavior.

Changes:

Added RasterImageCommand and new raster-image APIs on IOutputBuffer with storage in OutputBufferImpl.
Updated OutputBase to render raster images during Write() and to include them in ToAnsi() output.
Updated ImageView to emit sixel via the output buffer (and added a new Mandelbrot UICatalog scenario for interactive testing).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Tests/UnitTestsParallelizable/Drivers/Output/OutputBaseTests.cs	Adds tests for raster-image clip capture, ANSI emission, skip-on-non-intersection, and ordering vs later dirty cells.
Terminal.Gui/Views/ImageView.cs	Switches sixel rendering from the out-of-band queue to `IOutputBuffer.AddRasterImage()`; removes old cached-queue state.
Terminal.Gui/Drivers/Output/RasterImageCommand.cs	Introduces a command object describing raster images for buffered composition.
Terminal.Gui/Drivers/Output/OutputBufferImpl.cs	Stores raster image commands and captures clip; marks covered cells clean to avoid redundant redraw.
Terminal.Gui/Drivers/Output/OutputBase.cs	Renders raster images as part of output composition and appends raster-image output in `ToAnsi()`.
Terminal.Gui/Drivers/Output/IOutputBuffer.cs	Adds raster image APIs (`AddRasterImage`, `RemoveRasterImage`, `GetRasterImages`).
Examples/UICatalog/Scenarios/Mandelbrot.cs	Adds an interactive Mandelbrot sixel scenario with overlay dialog to exercise clipping/composition.

Add regression coverage for raster command IDs, stale cell invalidation, and ToAnsi layering. Update raster buffer replacement/removal to dirty stale image cells and make ToAnsi emit raster images before text overlays. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ion-plan

… tig/sixel-integration-plan

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…output Switch Terminal.Gui from NuGet (2.4.3) to local project reference targeting the tig/sixel-integration-plan branch (gui-cs/Terminal.Gui#5460) which provides integrated raster image output with proper clipping, Z-order, and invalidation. Removed from PreviewPane: - Mouse drag-to-pan (GrabMouse/UngrabMouse, position tracking) - Scroll-wheel and keyboard zoom (+/-/0) - SuspendSixel/ResumeSixel dialog workaround - Manual pixel-budget calculation (Frame * cell-size assumptions) - MaterializeSample fallback helper Removed from PageRenderer: - Zoom, PanX, PanY properties and associated transform math Removed from MainView: - RunnableOpening/RunnableClosed → SuspendSixel/ResumeSixel wiring Deleted: - ImageLoader.cs (dead code) - Resources/preview-sample.png (unused fallback asset) Also includes prior uncommitted work: - fix: settings changes now update preview (SettingsChanged subscription) - fix: sheet change reloads file (SheetApplied handler) - UI border/thickness/scheme tweaks and comment cleanup - Regenerated all 11 golden snapshots Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 33 out of 35 changed files in this pull request and generated 6 comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

BDisp

This is truly an excellent implementation. I only noticed a change in the image colors when the border of a dialog box is overlapped, as shown in the image below. You might also want to update Mandelbrot.gif to the current appearance.

Prototype integrated sixel raster output

fd87e87

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread Terminal.Gui/Drivers/Output/OutputBase.cs Outdated

tig changed the title ~~Fixes #5459. Prototype integrated sixel raster output~~ Fixes #5459. Integrated sixel raster output Jun 1, 2026

Make Mandelbrot image resizable

8c6f4f1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tig requested a review from Copilot June 1, 2026 12:06

Copilot started reviewing on behalf of tig June 1, 2026 12:07 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread Terminal.Gui/Drivers/Output/OutputBufferImpl.cs

Comment thread Terminal.Gui/Drivers/Output/OutputBufferImpl.cs

Comment thread Terminal.Gui/Drivers/Output/OutputBufferImpl.cs

Comment thread Terminal.Gui/Drivers/Output/OutputBase.cs Outdated

tig and others added 7 commits June 1, 2026 06:25

Add Mandelbrot recording docs

dd9d9c8

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Scale Mandelbrot rendering on resize

da75a99

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add fire progress style and fix Mandelbrot layout

1928c83

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/develop' into tig/sixel-integrat…

3cd20f4

…ion-plan

Merge remote-tracking branch 'origin/tig/sixel-integration-plan' into…

dbbcd89

… tig/sixel-integration-plan

Improve Mandelbrot interaction and fire overlay

20a5759

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tig and others added 4 commits June 1, 2026 16:32

Refactoring

f0f7abe

Refactor ImageView rendering

12854e2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Include remaining Image scenario updates

1f13fda

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Ignore generated snapshot actuals

832e0b0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tig requested review from BDisp, YourRobotOverlord, Copilot, harder and tznind June 2, 2026 00:07

Copilot started reviewing on behalf of tig June 2, 2026 00:07 View session

tig changed the title ~~Fixes #5459. Integrated sixel raster output~~ Fixes #5459. Integrated sixel raster output, improved ImageView and scenarios Jun 2, 2026

Copilot AI reviewed Jun 2, 2026

View reviewed changes

tig and others added 2 commits June 1, 2026 18:19

Address sixel review feedback

cb2faa9

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Keep image commands grouped

698abbb

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

BDisp approved these changes Jun 2, 2026

View reviewed changes

tig merged commit 27bdcf0 into develop Jun 2, 2026
13 checks passed

tig deleted the tig/sixel-integration-plan branch June 2, 2026 01:35

This was referenced Jun 2, 2026

Bump the nuget-dependencies group with 6 updates jamesshenry/Terminal.Gui.Stanza#2

Closed

Bump Terminal.Gui from 1.19.0 to 2.4.4 jas88/RDMP#224

Open

Bump Terminal.Gui from 2.4.1 to 2.4.4 Yuta-K19418/DataMorph#220

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #5459. Integrated sixel raster output, improved `ImageView` and scenarios#5460

Fixes #5459. Integrated sixel raster output, improved `ImageView` and scenarios#5460
tig merged 15 commits into
developfrom
tig/sixel-integration-plan

tig commented Jun 1, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BDisp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tig commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BDisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tig commented Jun 1, 2026 •

edited

Loading