Release v2.4.3

.github/workflows/README.md

@@ -15,7 +15,7 @@ The repository uses multiple GitHub Actions workflows. What runs and when:
 - `dotnet restore`
 - Build Debug: `dotnet build --configuration Debug --no-restore -property:NoWarn=0618%3B0612`
 - Build Release (library): `dotnet build Terminal.Gui/Terminal.Gui.csproj --configuration Release --no-incremental --force -property:NoWarn=0618%3B0612`
-- Pack Release: `dotnet pack Terminal.Gui/Terminal.Gui.csproj --configuration Release --output ./local_packages -property:NoWarn=0618%3B0612`
+- Pack Release packages: `dotnet pack Terminal.Gui/Terminal.Gui.csproj --configuration Release --output ./local_packages -property:NoWarn=0618%3B0612` and `dotnet pack Terminal.Gui.Interop.Spectre/Terminal.Gui.Interop.Spectre.csproj --configuration Release --output ./local_packages -property:NoWarn=0618%3B0612`
 - Publish `Tests/NativeAotSmoke` with AOT and run `--smoke-test`
 - Build Release solution
 
@@ -66,14 +66,11 @@ The repository uses multiple GitHub Actions workflows. What runs and when:
 
 ### 5) Publish to NuGet (`.github/workflows/publish.yml`)
 
-- **Triggers**: push to `main`, `develop`, and tags `v*`(ignores `**.md`)
-- Uses GitVersion to compute SemVer, builds Release, packs with symbols, and pushes to NuGet.org using `NUGET_API_KEY`
+- **Triggers**: push to `develop` and tags `v*` (ignores `**.md`)
+- Uses GitVersion to compute SemVer, builds Release, packs Terminal.Gui and Terminal.Gui.Interop.Spectre with symbols, and pushes both to NuGet.org using `NUGET_API_KEY`
 - **Automatically triggered** by the Create Release workflow when a new tag is pushed
-- **Additional actions on main branch**:
-  - Delists old NuGet packages to keep package list clean:
-    - Keeps only the most recent `*-develop.*` package
-    - Keeps only the just-published `*-beta.*` or `*-rc.*` package
-  - Triggers Terminal.Gui.templates repository update via repository_dispatch (requires `PAT_FOR_TEMPLATES` secret)
+- **Additional actions on tag push** (`v*`):
+  - Triggers Terminal.Gui.templates repository update via repository_dispatch (requires `TEMPLATE_REPO_TOKEN` secret)
 
 ### 6) Build and publish API docs (`.github/workflows/api-docs.yml`)
 

.github/workflows/build-validation.yml

@@ -50,6 +50,9 @@ jobs:
     - name: Pack Release Terminal.Gui
       run: dotnet pack Terminal.Gui/Terminal.Gui.csproj --configuration Release --output ./local_packages -property:NoWarn=0618%3B0612
 
+    - name: Pack Release Terminal.Gui.Interop.Spectre
+      run: dotnet pack Terminal.Gui.Interop.Spectre/Terminal.Gui.Interop.Spectre.csproj --configuration Release --output ./local_packages -property:NoWarn=0618%3B0612
+
     - name: AOT Publish Test App (catches trimming and reflection errors)
       run: dotnet publish ./Tests/NativeAotSmoke/NativeAotSmoke.csproj --configuration Release --output ./aot-publish -property:NoWarn=0618%3B0612
 

.github/workflows/publish.yml

@@ -10,6 +10,9 @@ on:
     paths-ignore:
       - '**.md'
 
+permissions:
+  contents: read
+
 jobs:
   publish:
     name: Build and Publish to Nuget.org
@@ -41,12 +44,17 @@ jobs:
         dotnet-version: 10.x
         dotnet-quality: 'ga'
 
-    - name: Build Release Terminal.Gui
-      run: dotnet build Terminal.Gui/Terminal.Gui.csproj --no-incremental --nologo --force --configuration Release
+    - name: Build Release Terminal.Gui packages
+      run: |
+        dotnet build Terminal.Gui/Terminal.Gui.csproj --no-incremental --nologo --force --configuration Release
+        dotnet build Terminal.Gui.Interop.Spectre/Terminal.Gui.Interop.Spectre.csproj --no-incremental --nologo --force --configuration Release
 
     - name: Pack Release Terminal.Gui ${{ steps.gitversion.outputs.SemVer }} for Nuget
       run: dotnet pack Terminal.Gui/Terminal.Gui.csproj -c Release --include-symbols --no-build
 
+    - name: Pack Release Terminal.Gui.Interop.Spectre ${{ steps.gitversion.outputs.SemVer }} for Nuget
+      run: dotnet pack Terminal.Gui.Interop.Spectre/Terminal.Gui.Interop.Spectre.csproj -c Release --include-symbols --no-build
+
     # - name: Test to generate Code Coverage Report
     #   run: |
     #     sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json
@@ -72,6 +80,9 @@ jobs:
     - name: Publish Terminal.Gui.${{ steps.gitversion.outputs.SemVer }} to NuGet.org
       run: dotnet nuget push Terminal.Gui/bin/Release/Terminal.Gui.${{ steps.gitversion.outputs.SemVer }}.nupkg --skip-duplicate --api-key ${{ secrets.NUGET_API_KEY }}
 
+    - name: Publish Terminal.Gui.Interop.Spectre.${{ steps.gitversion.outputs.SemVer }} to NuGet.org
+      run: dotnet nuget push Terminal.Gui.Interop.Spectre/bin/Release/Terminal.Gui.Interop.Spectre.${{ steps.gitversion.outputs.SemVer }}.nupkg --skip-duplicate --api-key ${{ secrets.NUGET_API_KEY }}
+
     # Deterministic version handoff to notify-clet.yml. Avoids the NuGet
     # search-API indexing lag that caused gui-cs/clet to skip TG develop.37
     # (see clet workflow run 25406348354). notify-clet.yml downloads this

Examples/UICatalog/Scenarios/EditorsAndHelpers/TreeViewEditor.cs

@@ -9,6 +9,7 @@ namespace UICatalog.Scenarios;
 public sealed class TreeViewEditor : EditorBase
 {
     private CheckBox? _cbMultiSelect;
+    private CheckBox? _cbCheckboxMode;
     private CheckBox? _cbShowBranchLines;
     private CheckBox? _cbColorExpandSymbol;
     private CheckBox? _cbInvertExpandSymbolColors;
@@ -66,6 +67,7 @@ private void SyncFromView ()
         }
 
         _cbMultiSelect!.Value = treeView.MultiSelect ? CheckState.Checked : CheckState.UnChecked;
+        _cbCheckboxMode!.Value = treeView.CheckboxMode ? CheckState.Checked : CheckState.UnChecked;
         _cbShowBranchLines!.Value = treeView.Style.ShowBranchLines ? CheckState.Checked : CheckState.UnChecked;
         _cbColorExpandSymbol!.Value = treeView.Style.ColorExpandSymbol ? CheckState.Checked : CheckState.UnChecked;
         _cbInvertExpandSymbolColors!.Value = treeView.Style.InvertExpandSymbolColors ? CheckState.Checked : CheckState.UnChecked;
@@ -81,10 +83,13 @@ private void TreeViewEditor_Initialized (object? s, EventArgs e)
         _cbMultiSelect = new CheckBox { Title = "MultiSelect", CanFocus = true };
         _cbMultiSelect.ValueChanging += (_, args) => SetBool (args, (tv, v) => tv.MultiSelect = v);
 
+        _cbCheckboxMode = new CheckBox { X = Pos.Right (_cbMultiSelect) + 1, Title = "CheckboxMode", CanFocus = true };
+        _cbCheckboxMode.ValueChanging += (_, args) => SetBool (args, (tv, v) => tv.CheckboxMode = v);
+
         _cbShowBranchLines = new CheckBox { Y = Pos.Bottom (_cbMultiSelect), Title = "ShowBranchLines", CanFocus = true };
         _cbShowBranchLines.ValueChanging += (_, args) => SetStyleBool (args, (style, v) => style.ShowBranchLines = v);
 
-        _cbColorExpandSymbol = new CheckBox { X = Pos.Right (_cbMultiSelect) + 1, Title = "ColorExpandSymbol", CanFocus = true };
+        _cbColorExpandSymbol = new CheckBox { X = Pos.Right (_cbCheckboxMode) + 1, Title = "ColorExpandSymbol", CanFocus = true };
         _cbColorExpandSymbol.ValueChanging += (_, args) => SetStyleBool (args, (style, v) => style.ColorExpandSymbol = v);
 
         _cbInvertExpandSymbolColors = new CheckBox
@@ -189,6 +194,7 @@ private void TreeViewEditor_Initialized (object? s, EventArgs e)
                                 };
 
         Add (_cbMultiSelect,
+             _cbCheckboxMode,
              _cbColorExpandSymbol,
              _cbShowBranchLines,
              _cbInvertExpandSymbolColors,

Examples/UICatalog/Scenarios/Wizards.cs

@@ -1,8 +1,6 @@
 #nullable enable
 
 // ReSharper disable AccessToDisposedClosure
-using Terminal.Gui.Views;
-
 namespace UICatalog.Scenarios;
 
 [ScenarioMetadata ("Wizards", "Demonstrates the Wizard class")]
@@ -35,15 +33,10 @@ public override void Main ()
         };
         win.Add (settingsFrame);
 
-        Label label = new ()
-        {
-            X = 0,
-            TextAlignment = Alignment.End,
-            Text = "_Title:"
-        };
+        Label label = new () { X = 0, TextAlignment = Alignment.End, Text = "_Title:" };
         settingsFrame.Add (label);
 
-        _titleEdit = new ()
+        _titleEdit = new TextField
         {
             X = Pos.Right (label) + 1,
             Y = Pos.Top (label),
@@ -53,32 +46,17 @@ public override void Main ()
         };
         settingsFrame.Add (_titleEdit);
 
-        CheckBox cbRun = new ()
-        {
-            Title = "_Run Wizard as a modal",
-            X = 0,
-            Y = Pos.Bottom (label),
-            Value = CheckState.Checked
-        };
+        CheckBox cbRun = new () { Title = "_Run Wizard as a modal", X = 0, Y = Pos.Bottom (label), Value = CheckState.Checked };
         settingsFrame.Add (cbRun);
 
-        Button showWizardButton = new ()
-        {
-            X = Pos.Center (),
-            Y = Pos.Bottom (cbRun),
-            IsDefault = true,
-            Text = "_Show Wizard"
-        };
+        Button showWizardButton = new () { X = Pos.Center (), Y = Pos.Bottom (cbRun), IsDefault = true, Text = "_Show Wizard" };
 
         settingsFrame.Add (showWizardButton);
 
-        label = new ()
-        {
-            X = Pos.Center (), Y = Pos.AnchorEnd (1), TextAlignment = Alignment.End, Text = "Action:"
-        };
+        label = new Label { X = Pos.Center (), Y = Pos.AnchorEnd (1), TextAlignment = Alignment.End, Text = "Action:" };
         win.Add (label);
 
-        _actionLabel = new ()
+        _actionLabel = new View
         {
             X = Pos.Right (label),
             Y = Pos.AnchorEnd (1),
@@ -96,32 +74,32 @@ public override void Main ()
         }
 
         cbRun.ValueChanged += (_, a) =>
-        {
-            if (a.NewValue == CheckState.Checked)
-            {
-                showWizardButton.Enabled = true;
-                _wizard!.X = Pos.Center ();
-                _wizard.Y = Pos.Center ();
-
-                win.Remove (_wizard);
-                _wizard.Dispose ();
-                _wizard = null;
-            }
-            else
-            {
-                showWizardButton.Enabled = false;
-                _wizard = CreateWizard ();
-                _wizard.Y = Pos.Bottom (settingsFrame) + 1;
-                win.Add (_wizard);
-            }
-        };
+                              {
+                                  if (a.NewValue == CheckState.Checked)
+                                  {
+                                      showWizardButton.Enabled = true;
+                                      _wizard!.X = Pos.Center ();
+                                      _wizard.Y = Pos.Center ();
+
+                                      win.Remove (_wizard);
+                                      _wizard.Dispose ();
+                                      _wizard = null;
+                                  }
+                                  else
+                                  {
+                                      showWizardButton.Enabled = false;
+                                      _wizard = CreateWizard ();
+                                      _wizard.Y = Pos.Bottom (settingsFrame) + 1;
+                                      win.Add (_wizard);
+                                  }
+                              };
 
         showWizardButton.Accepting += (_, _) =>
-        {
-            _wizard = CreateWizard ();
-            app.Run (_wizard);
-            _wizard.Dispose ();
-        };
+                                      {
+                                          _wizard = CreateWizard ();
+                                          app.Run (_wizard);
+                                          _wizard.Dispose ();
+                                      };
 
         app.Run (win);
     }
@@ -130,7 +108,7 @@ private Wizard CreateWizard ()
     {
         Wizard wizard = new ();
 
-        if (_titleEdit is not null)
+        if (_titleEdit is { })
         {
             wizard.Title = _titleEdit.Text;
         }
@@ -161,7 +139,7 @@ private Wizard CreateWizard ()
                                 }
                                 else
                                 {
-                                    wizard.App!.RequestStop();
+                                    wizard.App!.RequestStop ();
                                     args.Handled = true;
                                 }
                             };

Terminal.Gui.Analyzers.Internal/EnumExtensionMethodsGenerator.cs

@@ -64,11 +64,11 @@ public void Initialize (IncrementalGeneratorInitializationContext context)
         // Only generate for int and uint backed enums.
         // Unsafe.As<TEnum, int/uint> requires the enum to be exactly 4 bytes.
         string? underlyingTypeName = symbol.EnumUnderlyingType?.SpecialType switch
-                                     {
-                                         SpecialType.System_Int32 => "int",
-                                         SpecialType.System_UInt32 => "uint",
-                                         _ => null
-                                     };
+        {
+            SpecialType.System_Int32 => "int",
+            SpecialType.System_UInt32 => "uint",
+            _ => null
+        };
 
         if (underlyingTypeName is null)
         {
@@ -91,15 +91,15 @@ public void Initialize (IncrementalGeneratorInitializationContext context)
             }
 
             int value = field.ConstantValue switch
-                        {
-                            int i => i,
-                            uint u => unchecked ((int)u),
-                            _ => 0
-                        };
+            {
+                int i => i,
+                uint u => unchecked((int)u),
+                _ => 0
+            };
             memberValues.Add (value);
         }
 
-        return new EnumInfo (enumNamespace, enumName, underlyingTypeName, hasFlags, memberValues.OrderBy (static v => unchecked ((uint)v)).ToArray ());
+        return new EnumInfo (enumNamespace, enumName, underlyingTypeName, hasFlags, memberValues.OrderBy (static v => unchecked((uint)v)).ToArray ());
     }
 
     private static void Execute (SourceProductionContext context, EnumInfo info)

Terminal.Gui/App/Application.cs

@@ -2,21 +2,21 @@
 // Put them here so they are available throughout the application.
 // Do not put them in AssemblyInfo.cs as it will break GitVersion's /updateassemblyinfo
 
-global using Attribute = Terminal.Gui.Drawing.Attribute;
-global using Color = Terminal.Gui.Drawing.Color;
-global using CM = Terminal.Gui.Configuration.ConfigurationManager;
 global using Terminal.Gui.App;
-global using Terminal.Gui.Testing;
-global using Terminal.Gui.Time;
+global using Terminal.Gui.Configuration;
+global using Terminal.Gui.Drawing;
 global using Terminal.Gui.Drivers;
+global using Terminal.Gui.FileServices;
 global using Terminal.Gui.Input;
-global using Terminal.Gui.Configuration;
+global using Terminal.Gui.Resources;
+global using Terminal.Gui.Testing;
+global using Terminal.Gui.Text;
+global using Terminal.Gui.Time;
 global using Terminal.Gui.ViewBase;
 global using Terminal.Gui.Views;
-global using Terminal.Gui.Drawing;
-global using Terminal.Gui.Text;
-global using Terminal.Gui.Resources;
-global using Terminal.Gui.FileServices;
+global using Attribute = Terminal.Gui.Drawing.Attribute;
+global using CM = Terminal.Gui.Configuration.ConfigurationManager;
+global using Color = Terminal.Gui.Drawing.Color;
 using System.Globalization;
 using System.Reflection;
 using System.Resources;

Terminal.Gui/App/ApplicationImpl.Run.cs

@@ -199,7 +199,7 @@ public void Invoke (Action action)
     #region Session Lifecycle - Run
 
     /// <inheritdoc/>
-    public IApplication Run<TRunnable> (Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new ()
+    public IApplication Run<TRunnable> (Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new()
     {
         if (!Initialized)
         {
@@ -314,7 +314,7 @@ public void Invoke (Action action)
     }
 
     /// <inheritdoc/>
-    public Task<IApplication> RunAsync<TRunnable> (CancellationToken cancellationToken, Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new ()
+    public Task<IApplication> RunAsync<TRunnable> (CancellationToken cancellationToken, Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new()
     {
         if (cancellationToken.IsCancellationRequested)
         {

Terminal.Gui/App/ApplicationImpl.Screen.cs

@@ -280,6 +280,15 @@ public void LayoutAndDraw (bool forceRedraw = false)
 
             // Only force a complete redraw if needed (needsLayout or forceRedraw).
             // Otherwise, just redraw views that need it.
+            //
+            // NOTE (#5358): passing force=true here calls SetNeedsDraw on the top runnable, which
+            // cascades to all overlapping subviews via the existing SetNeedsDraw recursion. This
+            // is the remaining draw-fan-out source documented by TabsFanOutIntegrationTests. The
+            // proper fix requires tracking adornment thickness changes (in addition to Frame
+            // changes) so the SuperView can be invalidated precisely instead of force-redrawing
+            // the whole tree. Dropping force-on-neededLayout without that tracking exposes
+            // stale-content bugs in the shrink/move and adornment-rebalance paths (covered by
+            // ShadowTests / BorderViewTests).
             View.Draw (views.ToArray ().Cast<View> (), neededLayout || forceRedraw);
 
             Driver.Clip = new Region (clipRect);

Terminal.Gui/App/Clipboard/ClipboardBase.cs

@@ -1,5 +1,5 @@
 #nullable disable
-using System.Diagnostics;
+using System.Diagnostics;
 
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/Clipboard/ClipboardProcessRunner.cs

@@ -38,7 +38,7 @@ public static (int exitCode, string result) Process (
 
         using var process = new Process ();
 
-        process.StartInfo = new()
+        process.StartInfo = new ()
         {
             FileName = cmd,
             Arguments = arguments,

Terminal.Gui/App/IApplication.cs

@@ -294,7 +294,7 @@ public interface IApplication : IDisposable
     ///         session.
     ///     </para>
     /// </remarks>
-    Task<IApplication> RunAsync<TRunnable> (CancellationToken cancellationToken, Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new ();
+    Task<IApplication> RunAsync<TRunnable> (CancellationToken cancellationToken, Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new();
 
     /// <summary>
     ///     Runs a new Session creating a <see cref="IRunnable"/>-derived object of type <typeparamref name="TRunnable"/>
@@ -340,7 +340,7 @@ public interface IApplication : IDisposable
     ///         The caller is responsible for disposing the object returned by this method.
     ///     </para>
     /// </remarks>
-    public IApplication Run<TRunnable> (Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new ();
+    public IApplication Run<TRunnable> (Func<Exception, bool>? errorHandler = null, string? driverName = null) where TRunnable : IRunnable, new();
 
     #region Iteration & Invoke