Fixes #5442. Windows VT input can hang during shutdown when ReadFile is blocked#5443
Merged
BDisp merged 1 commit intoMay 28, 2026
Merged
Conversation
…dFile is blocked
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows shutdown hang where the ANSI driver's input thread could be stuck inside synchronous ReadFile. Adds a CancelIoEx-based wake helper invoked during AnsiOutput.Dispose, and treats ERROR_OPERATION_ABORTED from ReadFile as normal cancellation rather than a warning.
Changes:
- Add
CancelIoExP/Invoke and a staticWakePendingRead()helper onWindowsVTInputHelper. - Silently treat
ERROR_OPERATION_ABORTED(995) fromReadFileas a benign cancellation. - Call
WakePendingRead()fromAnsiOutput.Disposewhen running on the WindowsVT platform.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Terminal.Gui/Drivers/WindowsHelpers/WindowsVTInputHelper.cs | Adds CancelIoEx interop, error constants, WakePendingRead() helper, and handles ERROR_OPERATION_ABORTED in TryRead. |
| Terminal.Gui/Drivers/AnsiDriver/AnsiOutput.cs | Invokes WindowsVTInputHelper.WakePendingRead() during dispose on the WindowsVT platform to unblock pending reads. |
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
ReadFileis blocked #5442Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)