Fixes #5438 - Update CheckState default glyphs#5439
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update indeterminate checkbox glyph for better distinction
Update CheckState default glyphs
May 28, 2026
tig
changed the title
tig
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the default CheckState glyphs so the three states are easier to distinguish in common terminal fonts: Checked becomes ☑ (was ☒), None becomes ⬛ (was □), UnChecked stays ☐. Bundled themes (TurboPascal 5, Anders) and related doc comments are updated to match, and a small unit test pins the new defaults.
Changes:
- Change
Glyphs.CheckStateCheckeddefault to ☑ andGlyphs.CheckStateNonedefault to ⬛. - Align bundled theme JSON overrides and CheckBox/ListView doc comments with the new defaults.
- Add a CheckBox unit test asserting the new default glyph values.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Terminal.Gui/Drawing/Glyphs.cs | New default runes for CheckStateChecked and CheckStateNone. |
| Terminal.Gui/Resources/config.json | Updates TurboPascal 5 and Anders theme overrides to match new defaults. |
| Terminal.Gui/Views/CheckBox.cs | Doc comment updated to describe ⬛ for CheckState.None. |
| Terminal.Gui/Views/ListView/ListView.Selection.cs | Doc comment updated from ☒ to ☑ for checkbox marks. |
| Terminal.Gui/Views/ListView/ListView.Drawing.cs | Inline comment updated from ☒ to ☑. |
| Tests/UnitTestsParallelizable/Views/CheckBoxTests.cs | New test pinning default CheckState glyph values. |
BDisp
approved these changes
May 28, 2026
tig
added a commit
that referenced
this pull request
May 28, 2026
- ToggleChecked now correctly handles all cases:
- If effective state is not UnChecked, toggle to UnChecked (propagates to children)
- If effective state is UnChecked but descendants have explicit checked state
(collapsed parent scenario), also toggle to UnChecked
- Only toggle to Checked when fully unchecked with no checked descendants
- Add HasCheckedDescendantsInState helper for collapsed-parent detection
- Add comprehensive mouse-click test that clicks children individually then
unchecks parent (mimics exact UICatalog user scenario)
- Revert Glyphs.cs emoji changes (PR #5439 handles glyph updates separately)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tig
added a commit
that referenced
this pull request
May 28, 2026
- ToggleChecked now correctly handles all cases:
- If effective state is not UnChecked, toggle to UnChecked (propagates to children)
- If effective state is UnChecked but descendants have explicit checked state
(collapsed parent scenario), also toggle to UnChecked
- Only toggle to Checked when fully unchecked with no checked descendants
- Add HasCheckedDescendantsInState helper for collapsed-parent detection
- Add comprehensive mouse-click test that clicks children individually then
unchecks parent (mimics exact UICatalog user scenario)
- Revert Glyphs.cs emoji changes (PR #5439 handles glyph updates separately)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Default CheckState glyphs made checked and indeterminate states harder to distinguish in common terminal fonts.
This PR also clarifies ListView mark-column behavior in code/docs so wide glyph rendering intent is explicit.
Proposed Changes/Todos
Glyphs.CheckStateCheckedfrom☒to☑Glyphs.CheckStateNonefrom□to⬛ListViewmark-width documentation and local naming to make wide-glyph spacing behavior explicitPull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)