Fixes #5358. Narrow draw pipeline to skip parent on child-only redraws by harder · Pull Request #5431 · gui-cs/Terminal.Gui

harder · 2026-05-27T19:19:21Z

Summary

Fixes Stop child-only redraws from escalating into full parent redraws #5358

Stops the parent's Draw() pipeline from clearing the viewport and redrawing its own text/content when only a subview is dirty. Adds the supporting infrastructure (true-union SetNeedsDraw, region-aware ClearViewport, SuperView invalidation on Frame change) so future work can also narrow the remaining fan-out source in ApplicationImpl.LayoutAndDraw.

Split from #4973. Layout fan-out was already fixed by #5373 (PR for #5357); this PR addresses the draw-pipeline half.

Root causes (verified against current `develop`)

DoDrawAdornments escalates NeedsDrawRect = Viewport when it was empty, which makes downstream DoClearViewport / DoDrawText / DoDrawContent run on every parent that was entered through SubViewNeedsDraw.
ClearViewport calls SetNeedsDraw() at the end — which cascades to every overlapping subview because the existing cascade in View.NeedsDraw.cs invalidates all intersecting children.
AdornmentView.OnClearingViewport calls SetNeedsDraw() mid-pass, propagating churn back up to the parent's SubViewNeedsDraw.
SetNeedsDraw(Rectangle) union math was buggy — it unioned against Viewport (not NeedsDrawRect) and used max(width, width) instead of Rectangle.Union, so NeedsDrawRect was effectively clamped to ~viewport-wide on every call. This made any region-aware narrowing impossible.

Changes

View.Draw() (View.Drawing.cs) — captures needsDrawSelf = NeedsDraw before DoDrawAdornments escalates NeedsDrawRect; gates DoClearViewport, DoDrawText, DoDrawContent on the captured value. DoDrawAdornments, DoDrawSubViews, DoDrawAdornmentsSubViews, and DoRenderLineCanvas still run as before so adornments and line-canvas joining keep working.
SetNeedsDraw(Rectangle) (View.NeedsDraw.cs) — replaces the buggy union math with Rectangle.Union(NeedsDrawRect, viewPortRelativeRegion) so NeedsDrawRect accurately tracks accumulated dirty regions.
DoClearViewport / ClearViewport (View.Drawing.cs) — public ClearViewport() keeps its original always-full-clear contract (preserves Code.OnClearingViewport, MarkdownCodeBlock, ClearViewport_FillsViewportArea, ClearViewport_SetsNeedsDraw semantics). Region-aware narrowing lives in a new private CanNarrowClearToNeedsDrawRect helper that the framework's DoClearViewport calls when (a) NeedsDrawRect is strictly smaller than the viewport AND (b) the view is not itself scrolled (Viewport.Location == Point.Empty). The "not itself scrolled" guard sidesteps a separate NeedsDrawRect coordinate-system ambiguity (the cascade in View.NeedsDraw.cs produces frame-local rects while SetNeedsDraw()-no-arg passes content-coord Viewport); normalizing that convention is deferred.
SetFrame (View.Layout.cs) — when a view's Frame shrinks or moves, calls SuperView.SetNeedsDraw(Rectangle.Union(originalFrame, Frame)) so the uncovered area gets cleared on the next draw via the framework's region-aware path. SetFrame is the single source of truth for _frame mutation: both view.Frame = ... and the layout-driven SetRelativeLayout → SetFrame paths go through it.
View.Draw() - _localDrawContext lifecycle (View.Drawing.cs) — only recreates the per-pass draw context when needsDrawSelf is true. On child-only passes the prior context is preserved, so DoDrawComplete doesn't overwrite a transparent view's CachedDrawnRegion with an empty region. Prevents TransparentMouse hit-testing from going dead after a child-only invalidation.
AdornmentView.OnClearingViewport (AdornmentView.cs) — removes the redundant SetNeedsDraw() call that cascaded back to the parent's SubViewNeedsDraw mid-draw. MarginView already overrides without it; BorderView and PaddingView (both : AdornmentView) inherit the cleaner base. Also refreshes the stale migration doc comment that still claimed Border and Padding extended Adornment directly.

Testing

dotnet build --no-restore
dotnet run --project Tests/UnitTestsParallelizable --no-build — 17276 tests pass / 17 pre-existing skips
dotnet run --project Tests/UnitTests.NonParallelizable --no-build — 74 pass / 2 skips
dotnet run --project Tests/IntegrationTests --no-build — 433 pass

New tests:

Tests/UnitTestsParallelizable/ViewBase/Draw/SubViewOnlyRedrawTests.cs (6 tests) — child-only invalidation does not clear or redraw the parent; transparent and bordered cases; IOutput-layer verification; transparent-mouse parent preserves CachedDrawnRegion across child-only passes.
Tests/UnitTestsParallelizable/ViewBase/Draw/RegionAwareClearViewportTests.cs (6 tests) — narrow-when-partial vs. full-clear-when-empty contract; Frame-change invalidates SuperView for the union of old and new frames; pure scroll does not invalidate SuperView; scrolled-view falls back to full clear.

Updated tests:

Tests/UnitTestsParallelizable/Views/TabView/TabsFanOutDiagnosticTests.cs — switched from DrawComplete (fires unconditionally for clip-exclusion bookkeeping) to DrawingText (gated on NeedsDraw, not intercepted by Code). Diagnostic-level inactive-tab fan-out now asserts == 0.
Tests/UnitTestsParallelizable/ViewBase/Draw/NeedsDrawTests.cs — NeedsDrawRect_Is_Viewport_Relative and SetNeedsDraw_MultipleRectangles_Expands updated to reflect proper accumulating union semantics (the old assertions were locking in the buggy "max-of-Viewport" behavior).
Tests/IntegrationTests/TabsFanOutIntegrationTests.cs — assertion message updated to point at the documented remaining cascade source (ApplicationImpl.LayoutAndDraw's force=true on neededLayout), which is out of scope for this PR.

Known remaining work (deferred to a follow-up)

#5434 Track adornment thickness deltas during layout so ApplicationImpl.LayoutAndDraw can stop passing force = neededLayout || forceRedraw; once that lands, TabsFanOutIntegrationTests can flip to assert integration fan-out == 0.
#5433 Make the View.Draw (...) self-draw / _localDrawContext flow explicit so the TransparentMouse cached-region contract stays behavior-safe and easier to maintain.

Code-review changes (CoPilot review of initial commits)

Four issues found in code review and addressed in commits 7479c2dda and ac2d48ffa:

Coordinate-space inconsistency between cascade (frame-local) and narrowing (content-coord) on scrolled subviews. Fix: guard narrowing on Viewport.Location == Point.Empty; full convention normalization deferred.
TransparentMouse CachedDrawnRegion wiped on child-only passes because _localDrawContext was recreated unconditionally. Fix: only recreate when needsDrawSelf is true.
Code / MarkdownCodeBlock full-clear contract broken by partial-narrow ClearViewport() (same root cause as 1). Fix: revert public ClearViewport to always-full-clear; narrowing only in the framework path.
Duplicate SuperView invalidation in SetFrame and Layout(Size). Fix: keep only SetFrame's — single source of truth.

To pull down this PR locally

git remote add copilot git@github.com:harder/Terminal.Gui.git
git fetch copilot fix-5358-stop-child-redraws-escalating
git checkout copilot/fix-5358-stop-child-redraws-escalating

…n-out Capture NeedsDraw at the top of View.Draw() before DoDrawAdornments mutates NeedsDrawRect, and gate DoClearViewport / DoDrawText / DoDrawContent on the captured value. When a parent enters Draw() only because SubViewNeedsDraw is true, its viewport is no longer cleared and its own text/content is no longer redrawn. Adornments, subviews, and line canvas still render correctly. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The escalation remains necessary for DoRenderLineCanvas and ClearNeedsDraw, but it no longer drives parent self-content redraws — those are now gated on the needsDrawSelf snapshot captured before this escalation. Updated the inline comment to reflect the narrowed purpose. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…ing draw Remove the redundant SetNeedsDraw() call in the base AdornmentView's OnClearingViewport. The thickness has just been drawn; calling SetNeedsDraw mid-pass cascades to the parent's SubViewNeedsDraw and adds churn that competes with the needsDrawSelf gate introduced for gui-cs#5358. MarginView already overrides without this call. BorderView and PaddingView, which inherit the base implementation, also benefit. Also refresh the stale class doc comment — Border and Padding now extend AdornmentView too. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Five tests covering the needsDrawSelf gate: - ChildOnlyDirty: parent does not clear/redraw self - ParentDirectlyDirty: full redraw path still works (regression guard) - TransparentParent: transparent early-return composes with the gate - ParentWithBorder: parent skips clear/text even with an adornment present - IOutput layer: child's render still reaches IOutput after the fix Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…-cs#5358 DrawComplete fires unconditionally for clip-exclusion bookkeeping even when NeedsDraw is false, so it is the wrong signal for measuring whether a view actually did draw work. Add a DrawingText counter to both the diagnostic and integration tests — DrawingText is gated on NeedsDraw inside DoDrawText and is not intercepted by Code (which does intercept ClearedViewport / DrawingContent via OnClearingViewport / OnDrawingContent returning true). Use DrawingText to verify per-Code inactive-tab behavior, and use tabsCounts.ClearedViewport to verify the parent's own behavior. TabsFanOutDiagnosticTests (synthetic Layout/Draw path) now asserts: - inactive tabs have DrawingText == 0 - Tabs container has ClearedViewport == 0 - text-draw fan-out ratio == 1.0 (parity with single-Code baseline) TabsFanOutIntegrationTests (end-to-end via main loop) keeps the existing "documents remaining fan-out" assertion: a separate cascade source remains in ApplicationImpl.LayoutAndDraw (force=true when neededLayout, calling SetNeedsDraw on the top runnable which cascades to overlapping subviews). Removing that force=true uncovers stale-content bugs in the shrink/move path (already covered by ShadowTests / BorderViewTests) and is out of scope for gui-cs#5358. Layout fan-out is fully eliminated by PR gui-cs#5373. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The previous union math at View.NeedsDraw.cs lines 87-92 was buggy: int x = Math.Min (Viewport.X, viewPortRelativeRegion.X); int y = Math.Min (Viewport.Y, viewPortRelativeRegion.Y); int w = Math.Max (Viewport.Width, viewPortRelativeRegion.Width); int h = Math.Max (Viewport.Height, viewPortRelativeRegion.Height); It unioned against Viewport (not against the existing NeedsDrawRect), and used max-of-Width / max-of-Height rather than Rectangle.Union. The result was that NeedsDrawRect was effectively clamped to the current Viewport size on every call — accumulated partial regions were silently widened to ~viewport-wide, making NeedsDrawRect useless for narrowing draw work. Replace with Rectangle.Union (NeedsDrawRect, viewPortRelativeRegion) so NeedsDrawRect accurately tracks the accumulated dirty area. This is required for issue gui-cs#5358's region-aware ClearViewport. Update NeedsDrawTests to reflect the new accumulating semantics: - NeedsDrawRect_Is_Viewport_Relative: shrink scenarios now keep the larger accumulated area (Union of prior larger frame and current smaller one) - SetNeedsDraw_MultipleRectangles_Expands: union of two non-overlapping rects is the bounding rect, not the full viewport Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

When NeedsDrawRect is set and genuinely smaller than the full viewport (i.e. a real partial-region invalidation, not SetNeedsDraw()-no-arg which sets the full Viewport), narrow the clear and the trailing SetNeedsDraw cascade to just that region. Otherwise preserve the existing full-clear contract used by Code.OnClearingViewport, MarkdownCodeBlock, and direct test callers (e.g. ClearViewport_FillsViewportArea, ClearViewport_SetsNeedsDraw). This is the second half of the infrastructure for issue gui-cs#5358's narrowed draw work: combined with the SuperView invalidation on Frame change added in the next commit, geometry changes will only clear and cascade to the affected region instead of forcing the whole viewport and all overlapping peers to redraw. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

When a view's Frame shrinks or moves, the SuperView's old-frame area is now uncovered and must be cleared on the next draw — otherwise stale content remains (e.g. an old shadow after a view shrinks). Add a SuperView.SetNeedsDraw (Rectangle.Union(originalFrame, Frame)) call in View.Layout(Size) when frameChanged. Combined with the region-aware ClearViewport from the previous commit, this clears only the union area and cascades NeedsDraw only to overlapping subviews intersecting that union — not the entire viewport. Note: this only catches Frame changes. Adornment thickness changes (e.g. a Margin shrinking when a shadow is removed) don't change Frame, so this fix doesn't help them. A future change can extend this by tracking adornment thickness deltas during Layout — at which point ApplicationImpl.LayoutAndDraw can drop force=true on neededLayout and the integration-level draw fan-out in TabsFanOutIntegrationTests can be flipped to assert == 0. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This is the cascade source that keeps TabsFanOutIntegrationTests bandaged. Removing force=true when only neededLayout (not forceRedraw) requires tracking adornment thickness changes so the SuperView can be invalidated precisely. Until that lands, ShadowTests and BorderViewTests rely on force=true to clear stale content after adornment thickness rebalances that don't change Frame. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…tests SetFrame is the direct-assignment path for view.Frame = ... (used by code that sets Frame outright). It bypasses Layout()'s frameChanged detection because SetFrame updates _frame before Layout runs. Add the same SuperView.SetNeedsDraw (Union(oldFrame, newFrame)) call in SetFrame so direct Frame assignments also trigger the region-aware uncovered-area clearing. Add RegionAwareClearViewportTests with 5 focused tests: - DirectCaller_EmptyNeedsDrawRect_ClearsFullViewport — backward-compat contract - PartialNeedsDrawRect_ClearsOnlyDirtyRegion — narrowing fires when partial - FullViewportNeedsDrawRect_ClearsFullViewport — SetNeedsDraw() no-arg path - FrameShrink_InvalidatesSuperViewWithUnionOfOldAndNewFrames — Step 3 catches it - Scroll_DoesNotInvalidateSuperView — pure scroll does not fan out Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…serve transparent cache CoPilot code review surfaced three correctness issues with the region-aware ClearViewport from the prior commit: 1. Coordinate-space inconsistency. SetNeedsDraw(Rectangle) cascades to subviews using frame-local coordinates (subtracts subview.Frame.X/Y), while the no-arg variant passes content-coord Viewport. For an unscrolled view those coincide; for a scrolled view they disagree, and my narrowing math (subtracting Viewport.X/Y) would shift the clear off-screen on a scrolled subview. 2. Code/MarkdownCodeBlock full-clear contract. Both call public ClearViewport() from their OnClearingViewport overrides expecting a full fill of the code-block background. With NeedsDrawRect set partial by the cascade, the narrowed clear left stale background in the un-cleared part of the viewport (visible when content has fewer lines than the viewport, etc.). Fix: revert public ClearViewport() to always full-clear. Move narrowing logic into a private CanNarrowClearToNeedsDrawRect helper invoked only from DoClearViewport (the framework's draw-pipeline entry point), guarded by Viewport.Location == Point.Empty so the scrolled-cascade ambiguity is sidestepped entirely. The Item 1 normalization (frame-local vs content-coord NeedsDrawRect) is a deeper refactor deferred as a follow-up. 3. TransparentMouse hit-region wipe. _localDrawContext was recreated unconditionally before the needsDrawSelf gate, but on child-only passes DoDrawText/DoDrawContent are skipped, so _localDrawContext stayed empty. DoDrawComplete then wrote that empty region into CachedDrawnRegion, breaking mouse hit-testing for transparent views until the next full self-redraw. Fix: only recreate _localDrawContext when needsDrawSelf is true. On child-only passes the prior context is preserved, so DoDrawComplete keeps the previously- cached drawn region. SetNeedsDraw nulls CachedDrawnRegion when the view is genuinely invalidated, so stale cache values are bounded by view lifecycle. Updated tests: - RegionAwareClearViewportTests: switched from testing the public ClearViewport API to testing the framework's DoClearViewport via Draw(). Added a FrameworkDraw_ScrolledView_FallsBackToFullClear test that locks in the scrolled-view guard from fix 1. - SubViewOnlyRedrawTests: added TransparentMouseParent_ChildOnlyDirty_ PreservesCachedDrawnRegion to lock in fix 3. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CoPilot review item 4: SetFrame() already calls SuperView.SetNeedsDraw(union) for every Frame mutation (both direct view.Frame=... and layout-driven paths go through SetFrame). The matching block in Layout(Size) repeated the union and the cascade work on the hot path this PR is trying to trim. The duplicate was idempotent (Rectangle.Union of identical rects produces the same rect), but the cascade-to-overlapping-subviews work ran twice. Refs gui-cs#5358 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR narrows the draw pipeline so child-only redraws no longer cause parent viewport clearing or parent text/content redraws, addressing issue #5358 while preserving adornment, line-canvas, and public ClearViewport() behavior.

Changes:

Gates parent self-drawing work on a pre-adornment NeedsDraw snapshot.
Fixes dirty-region union semantics and adds region-aware framework clearing.
Adds/updates regression tests for child-only redraws, tab fan-out diagnostics, frame-change invalidation, and remaining integration-level fan-out.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`Terminal.Gui/ViewBase/View.Drawing.cs`	Adds self-redraw gating and region-aware `DoClearViewport` narrowing.
`Terminal.Gui/ViewBase/View.Drawing.Adornments.cs`	Updates comments around adornment-driven `NeedsDrawRect` escalation.
`Terminal.Gui/ViewBase/View.NeedsDraw.cs`	Replaces broken dirty-rect expansion with `Rectangle.Union`.
`Terminal.Gui/ViewBase/View.Layout.cs`	Invalidates the SuperView for old/new frame union on frame changes.
`Terminal.Gui/ViewBase/Adornment/AdornmentView.cs`	Removes redundant mid-clear `SetNeedsDraw()` cascade and updates docs.
`Terminal.Gui/App/ApplicationImpl.Screen.cs`	Documents the remaining `LayoutAndDraw` force-redraw fan-out source.
`Tests/UnitTestsParallelizable/ViewBase/Draw/SubViewOnlyRedrawTests.cs`	Adds focused child-only redraw regression coverage.
`Tests/UnitTestsParallelizable/ViewBase/Draw/RegionAwareClearViewportTests.cs`	Adds coverage for partial clears, full-clear contracts, and frame/scroll cases.
`Tests/UnitTestsParallelizable/ViewBase/Draw/NeedsDrawTests.cs`	Updates expectations for true dirty-region union behavior.
`Tests/UnitTestsParallelizable/Views/TabView/TabsFanOutDiagnosticTests.cs`	Switches diagnostics to `DrawingText` and asserts inactive tabs avoid NeedsDraw-gated work.
`Tests/IntegrationTests/TabsFanOutIntegrationTests.cs`	Tracks `DrawingText` and documents remaining integration-level fan-out.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ting

tig

This is really good stuff. Challenging. So glad we have the AIs to help.

NeedsDrawRect and the viewPortRelativeRegion parameter of SetNeedsDraw are now in viewport-LOCAL coords: (0, 0) is the top-left visible cell of the View's Viewport, independent of Viewport.Location (scroll offset, possibly negative under AllowNegativeX/Y). Previously the no-arg SetNeedsDraw() passed Viewport (with the scroll offset baked in), DoDrawAdornments escalation did the same, and the subview cascade compared parent's viewport-relative region to subview.Frame (in parent's content coords) without accounting for the parent's scroll. PR gui-cs#5431 worked around the resulting inconsistency by gating its region-aware ClearViewport narrowing on "Viewport.Location == Point.Empty"; this commit normalizes the convention so that workaround can be removed in a follow-up commit. Changes: - SetNeedsDraw() no-arg now passes new (Point.Empty, Viewport.Size). - DoDrawAdornments NeedsDrawRect escalation does the same. - SetNeedsDraw(Rectangle) subview cascade translates the viewport-local region through: parent scroll -> content coords -> intersect with subview.Frame -> subview frame-local -> subtract subview adornment offset and subview scroll -> clip to subview viewport bounds. If the result is empty (dirty area is only in subview's adornments/scrolled- off content), fall back to a no-arg subview SetNeedsDraw so the subview redraws safely. - View.Layout.SetFrame translates the union(old, new) frame from SuperView content coords to SuperView viewport-local before passing to SuperView.SetNeedsDraw. - Update NeedsDrawRect_Is_Viewport_Relative test scrolled-frame assertions to reflect the new convention (NeedsDrawRect no longer acquires scroll-position offsets). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…e normalized PR gui-cs#5431 added a "Viewport.Location == Point.Empty" early-return to CanNarrowClearToNeedsDrawRect because the cascade in SetNeedsDraw produced rects in a different coordinate space than ViewportToScreen expects. Issue gui-cs#5359 normalized NeedsDrawRect on viewport-local coordinates, so the conversion via ViewportToScreen is now safe regardless of the view's scroll state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Extract the self-content draw (Text + Content + local-context merge) into a private DrawSelfContent helper that owns the full _localDrawContext lifecycle for a self-redraw pass: create, populate, merge. Move the context creation out of the viewport-clear block — DoClearViewport only writes the shared context, so the local context isn't needed until DrawSelfContent, keeping create/populate /merge in one place. This replaces three separate `if (needsDrawSelf)` blocks (whose alignment had to be maintained by hand) with a clear/self split documented as intentional around DoDrawSubViews, plus an authoritative lifecycle comment on the _localDrawContext field describing why it is preserved across child-only passes (TransparentMouse CachedDrawnRegion contract from gui-cs#5431). Behavior-preserving; draw order unchanged. Side effect: collapsing creation and use into one method lets nullable flow analysis prove _localDrawContext non-null, removing a CS8602 warning. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

mrazza · 2026-05-29T20:15:38Z

This is awesome thank you.

harder and others added 12 commits May 26, 2026 14:05

harder requested a review from Copilot May 27, 2026 20:24

Copilot started reviewing on behalf of harder May 27, 2026 20:24 View session

harder mentioned this pull request May 27, 2026

Follow up #5431: make View.Draw self-draw context flow explicit #5433

Closed

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread Terminal.Gui/ViewBase/View.Layout.cs Outdated

Updated stale comment

d9533fd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

harder marked this pull request as ready for review May 27, 2026 20:36

harder requested a review from tig as a code owner May 27, 2026 20:36

harder mentioned this pull request May 27, 2026

Follow up #5431: track adornment thickness deltas so LayoutAndDraw can stop force-drawing #5434

Open

Merge branch 'gui-cs:develop' into fix-5358-stop-child-redraws-escala…

030150d

…ting

harder mentioned this pull request May 27, 2026

Fixes #5359. Normalize NeedsDrawRect to viewport-local coordinates #5435

Merged

tig approved these changes May 28, 2026

View reviewed changes

harder merged commit 73b38a8 into gui-cs:develop May 28, 2026
13 checks passed

harder deleted the fix-5358-stop-child-redraws-escalating branch May 28, 2026 03:18

harder mentioned this pull request May 28, 2026

Fixes #5433. Make View.Draw self-draw context flow explicit #5440

Merged

dependabot Bot mentioned this pull request Jun 1, 2026

Bump the dotnet-dependencies group with 13 updates jntm7/pitterm#7

Open

harder mentioned this pull request Jun 1, 2026

Fixes #5434. Track adornment thickness deltas so LayoutAndDraw can stop force-drawing #5464

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #5358. Narrow draw pipeline to skip parent on child-only redraws#5431

Fixes #5358. Narrow draw pipeline to skip parent on child-only redraws#5431
harder merged 14 commits into
gui-cs:developfrom
harder:fix-5358-stop-child-redraws-escalating

harder commented May 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

tig left a comment

Uh oh!

Uh oh!

mrazza commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

harder commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root causes (verified against current develop)

Changes

Testing

Known remaining work (deferred to a follow-up)

Code-review changes (CoPilot review of initial commits)

To pull down this PR locally

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

tig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrazza commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

harder commented May 27, 2026 •

edited

Loading

Root causes (verified against current `develop`)