Audit and fix inaccuracies in AI guidance files#5424
Merged
Conversation
Correct claims in CLAUDE.md and .claude/rules that drifted from the actual codebase/config: - CLAUDE.md: use MTP filter flags (--filter-method/--filter-class) for single-test runs; drop dangling scenario-modernization.md reference; list the existing unicode-graphemes.md rule. - event-patterns.md: local functions use PascalCase, matching the .editorconfig local_functions_rule (upper_camel_case_style). - testing-patterns.md: point non-parallel tests at the real Tests/UnitTests.NonParallelizable project; reference UnitTests.Legacy as the do-not-add project; replace the phantom coverlet.runsettings with the actual coverage/setup mechanism. https://claude.ai/code/session_01Msd5RHe9K8JR55YXTZEtdn
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s AI-agent guidance documentation to match the current Terminal.Gui codebase/config (test project names, test runner/filter flags, rule links, and naming rules), reducing drift-related misinformation for contributors and agents.
Changes:
- Updated
CLAUDE.mdto include the existing unicode/grapheme rule, remove a non-existent task link, and switch single-test examples to Microsoft Testing Platform filtering flags. - Updated
.claude/rules/testing-patterns.mdto reference the actual non-parallel test project and replace stale coverage/runsettings guidance with the current mechanism. - Updated
.claude/rules/event-patterns.mdto align local-function naming guidance with.editorconfig.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CLAUDE.md |
Fixes rule/task links and corrects test command examples for the repo’s MTP runner setup. |
.claude/rules/testing-patterns.md |
Corrects test project naming and updates guidance about environment setup and coverage tooling. |
.claude/rules/event-patterns.md |
Aligns local-function naming guidance with the enforced .editorconfig naming rule. |
- Drop the "Includes --diagnostic flag" characteristic from the non-parallel section; the example command omits it and CI uses --diagnostic for the parallelizable runs too, so it was misleading. - Reword the coverage note so it no longer conflicts with the "Code Coverage" section: the coverlet.collector package is referenced, but coverage is not actively collected in CI yet. https://claude.ai/code/session_01Msd5RHe9K8JR55YXTZEtdn
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited the AI-agent guidance files (
CLAUDE.mdand.claude/rules/*) for claims that have drifted from the actual codebase/config, and corrected them. Each fix is backed by the real source/config rather than assumption.--filter-method/--filter-class) instead of the VSTest-only--filter "FullyQualifiedName~...". Confirmed the test projects arexunit.v3withOutputType=Exe(MTP runner)..claude/tasks/scenario-modernization.mdlink — that file does not exist (.claude/tasks/contains onlybuild-app.mdandclean-code-review.md).unicode-graphemes.mdrule to the "Detailed Rules" list, where it was missing..claude/rules/event-patterns.md— Local-function naming corrected from camelCase to PascalCase, matching.editorconfig'slocal_functions_rule(upper_camel_case_style, warning severity) and real code (OnButtonClicked,OnMouseLeave, …)..claude/rules/testing-patterns.md— Non-parallel section now points at the realTests/UnitTests.NonParallelizableproject (Tests/UnitTestsdoes not exist); namesUnitTests.Legacyas the do-not-add project; replaces the phantomcoverlet.runsettingsreference (no.runsettingsfile exists and MTP ignores them) with the actual mechanism — thecoverlet.collectorpackage plusTests/TestEnvironmentSetup.cs.Verified-and-already-correct (left unchanged): C# 14 / net10.0, all
docfx/docs/*links, thevar-for-built-in-types rule (matches ReSharperuse_var_when_evident), and theBenchmarks/StressTests/IntegrationTestsdirectory references.Test plan
dotnet test --project Tests/UnitTests.NonParallelizable --no-buildand--filter-method "*MyTestMethod"resolve against existing projects.CLAUDE.md/.claude/rules/*now resolve.https://claude.ai/code/session_01Msd5RHe9K8JR55YXTZEtdn
Generated by Claude Code