Skip to content

Expands WideGlyphs tester to include ZJW emojis#5400

Merged
tig merged 1 commit into
gui-cs:developfrom
BDisp:add-zwj-emojis
May 25, 2026
Merged

Expands WideGlyphs tester to include ZJW emojis#5400
tig merged 1 commit into
gui-cs:developfrom
BDisp:add-zwj-emojis

Conversation

@BDisp

@BDisp BDisp commented May 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes

  • Fixes #_____

Proposed Changes/Todos

  • Add 10 emojis using ZWJ.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner May 24, 2026 23:56
@tig

tig commented May 25, 2026

Copy link
Copy Markdown
Member

Do you know of any terminals this fails on. If so we should update table in the bug template.

@BDisp

BDisp commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

Do you know of any terminals this fails on. If so we should update table in the bug template.

My preferred terminal in WSLg is Ghostty with the appropriate fonts installed. It also supports KKP and ZWJ. See the output below, without errors:

Captura de ecrã 2026-05-25 141604

Fails on:

Bash:

Captura de ecrã 2026-05-25 132708

Kitty:

image

@tig tig changed the title Add 10 emojis with ZWJ Expand WideGlyphs tester to include ZJW emojis May 25, 2026
@tig tig changed the title Expand WideGlyphs tester to include ZJW emojis Expands WideGlyphs tester to include ZJW emojis May 25, 2026
@tig tig merged commit 6af5590 into gui-cs:develop May 25, 2026
13 checks passed
@BDisp BDisp deleted the add-zwj-emojis branch May 25, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants