Fixes #5369 - BREAKING CHANGE - Move IAcceptTarget to Terminal.Gui.Input namespace#5395
Open
Copilot wants to merge 2 commits into
Open
Fixes #5369 - BREAKING CHANGE - Move IAcceptTarget to Terminal.Gui.Input namespace#5395Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/19d654fa-b670-4cdd-b63e-f32c36ab631f Co-authored-by: tig <585482+tig@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move IAcceptTarget to Terminal.Gui.Input namespace
Move IAcceptTarget to Terminal.Gui.Input namespace
May 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Moves IAcceptTarget into the Terminal.Gui.Input namespace to align it with the rest of the command/input API surface, and updates docs/tests to reflect the new UID/namespace.
Changes:
- Moved
IAcceptTargetfromTerminal.Gui→Terminal.Gui.Input. - Updated DocFX docs/xref UIDs referencing
IAcceptTargetto the new namespace. - Added a unit test asserting
IAcceptTarget’s namespace to prevent regressions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Terminal.Gui/Input/IAcceptTarget.cs | Changes the interface namespace to Terminal.Gui.Input. |
| docfx/README.md | Updates namespace prefix/UID documentation for IAcceptTarget. |
| docfx/docs/command.md | Updates xref references from Terminal.Gui.IAcceptTarget to Terminal.Gui.Input.IAcceptTarget. |
| docfx/docs/command-diagrams.md | Updates xref reference in diagrams text to the new namespace. |
| Tests/UnitTestsParallelizable/ViewBase/ViewCommandTests.cs | Adds a test asserting IAcceptTarget is in Terminal.Gui.Input. |
BDisp
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
IAcceptTargetfromnamespace Terminal.Guitonamespace Terminal.Gui.Inputto co-locate it with related command/input types (Command,CommandBinding,ICommandContext, etc.).Breaking Change
This is a binary-breaking namespace move. Any downstream code referencing
Terminal.Gui.IAcceptTargetin compiled IL will fail withTypeLoadExceptionunless recompiled.Changes
Terminal.Gui/Input/IAcceptTarget.cs—namespace Terminal.Gui;→namespace Terminal.Gui.Input;docfx/README.md,docfx/docs/command.md,docfx/docs/command-diagrams.md— Updated xref/doc referencesTests/UnitTestsParallelizable/ViewBase/ViewCommandTests.cs— Namespace assertion testCross-Dependency Coordination Plan (TG ↔ TG.Editor)
Lessons Learned from #5372 / #5378 / #5386
The
Bind/PlatformKeyBindingnamespace move required a painful 3-PR dance:local_packages/hack (local.nupkgof Editor built against new namespace)Why This PR Is Lower Risk
IAcceptTargetis not referenced in thegui-cs/Editorsource or compiled package (verified via GitHub code search). The Editor package will not throwTypeLoadExceptionfrom this move alone.Release Sequencing Plan
This PR will not be released until after PR #5371 (View.Text CWP / non-virtual — another breaking change) is also merged, so we batch both into a single
.minorversion bump.Step-by-step merge & release order:
No Local Package Hack Needed This Time
Unlike the
Bind/PlatformKeyBindingmove (#5378), we do not need alocal_packages/workaround because:IAcceptTargethas no compiled references in Editor's ILTerminalGuiVersionpin (2.4.0) will simply be bumped to≥ 2.5.0after TG releasesCI/CD Monitoring Checkpoints
developgui-cs/Terminal.Guigui-cs/Editorgui-cs/Terminal.Guigui-cs/Editorgui-cs/Terminal.GuiRisk Mitigation
IAcceptTargetusage before merge: Addusing Terminal.Gui.Input;to affected Editor files in the Phase 2 PRIAcceptTarget) — no user-facing breakagedevelopbefore tagging — the namespace move is a single-commit changeVerification
Pull Request checklist:
dotnet testbefore commit///style comments)